Skip to content

Add RubyMine and WebStorm as IDEs #13488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/jetbrains-auto-update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,21 @@ jobs:
projectId: ${{ secrets.GCP_PROJECT_ID }}
serviceAccountKey: ${{ secrets.GCP_SA_KEY }}
slackWebhook: ${{ secrets.IDE_SLACK_WEBHOOK }}
rubymine:
uses: ./.github/workflows/jetbrains-auto-update-template.yml
with:
productId: rubymine
productCode: RM
secrets:
projectId: ${{ secrets.GCP_PROJECT_ID }}
serviceAccountKey: ${{ secrets.GCP_SA_KEY }}
slackWebhook: ${{ secrets.IDE_SLACK_WEBHOOK }}
webstorm:
uses: ./.github/workflows/jetbrains-auto-update-template.yml
with:
productId: webstorm
productCode: WS
secrets:
projectId: ${{ secrets.GCP_PROJECT_ID }}
serviceAccountKey: ${{ secrets.GCP_SA_KEY }}
slackWebhook: ${{ secrets.IDE_SLACK_WEBHOOK }}
20 changes: 20 additions & 0 deletions .github/workflows/jetbrains-updates.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,23 @@ jobs:
exampleRepo: https://github.com/gitpod-io/template-php-laravel-mysql
secrets:
slackWebhook: ${{ secrets.IDE_SLACK_WEBHOOK }}
rubymine:
uses: ./.github/workflows/jetbrains-updates-template.yml
with:
productName: RubyMine
productId: rubymine
productCode: RM
productType: release
exampleRepo: https://github.com/gitpod-io/template-jetbrains-rubymine
secrets:
slackWebhook: ${{ secrets.IDE_SLACK_WEBHOOK }}
webstorm:
uses: ./.github/workflows/jetbrains-updates-template.yml
with:
productName: WebStorm
productId: webstorm
productCode: WS
productType: release
exampleRepo: https://github.com/gitpod-io/template-jetbrains-webstorm
Comment on lines +56 to +66
Copy link
Contributor

@felladrin felladrin Sep 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice [Non-Blocking]: We need to review/unarchive these two example repos:

/cc @loujaybee

Alternatively, we could use the following up-to-date templates for:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, will take a look at them, shouldn't block this PR, though, right?

CC: @Siddhant-K-code - let's add this to the backlog to review.

Copy link
Member

@Siddhant-K-code Siddhant-K-code Sep 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think.

secrets:
slackWebhook: ${{ secrets.IDE_SLACK_WEBHOOK }}
2 changes: 2 additions & 0 deletions WORKSPACE.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ defaultArgs:
golandDownloadUrl: "https://download.jetbrains.com/go/goland-2022.2.3.tar.gz"
pycharmDownloadUrl: "https://download.jetbrains.com/python/pycharm-professional-2022.2.2.tar.gz"
phpstormDownloadUrl: "https://download.jetbrains.com/webide/PhpStorm-2022.2.2.tar.gz"
rubymineDownloadUrl: "https://download.jetbrains.com/ruby/RubyMine-2022.2.2.tar.gz"
webstormDownloadUrl: "https://download.jetbrains.com/webstorm/WebStorm-2022.2.2.tar.gz"
REPLICATED_API_TOKEN: ""
REPLICATED_APP: ""
provenance:
Expand Down
4 changes: 4 additions & 0 deletions components/BUILD.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ packages:
- components/ide/jetbrains/image:phpstorm-latest
- components/ide/jetbrains/image:pycharm
- components/ide/jetbrains/image:pycharm-latest
- components/ide/jetbrains/image:rubymine
- components/ide/jetbrains/image:rubymine-latest
- components/ide/jetbrains/image:webstorm
- components/ide/jetbrains/image:webstorm-latest
- components/image-builder-bob:docker
- components/image-builder-mk3:docker
- components/local-app:docker
Expand Down
34 changes: 34 additions & 0 deletions components/ide-proxy/static/image/ide-logo/rubymineLogo.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions components/ide-proxy/static/image/ide-logo/webstormLogo.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions components/ide/jetbrains/image/BUILD.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@ const ideConfigs = [
name: "phpstorm",
productCode: "PS",
},
{
name: "rubymine",
productCode: "RM",
},
{
name: "webstorm",
productCode: "WS",
},
];

const packages = [];
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"entrypoint": "/ide-desktop/startup.sh",
"entrypointArgs": [ "{DESKTOPIDEPORT}", "rubymine", "Open in RubyMine" ],
"readinessProbe": {
"type": "http",
"http": {
"path": "/status"
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"entrypoint": "/ide-desktop/startup.sh",
"entrypointArgs": [ "{DESKTOPIDEPORT}", "webstorm", "Open in WebStorm" ],
"readinessProbe": {
"type": "http",
"http": {
"path": "/status"
}
}
}
60 changes: 58 additions & 2 deletions install/installer/cmd/testdata/render/aws-setup/output.golden

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

60 changes: 58 additions & 2 deletions install/installer/cmd/testdata/render/azure-setup/output.golden

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading