Skip to content

[jb] Port Forwarding in v2022.3 #12226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Aug 19, 2022

Description

Preview for the upcoming release of JetBrains, where we should have more control over the info displayed on UI about forwarded ports.

Note: We won't be able to see it in a Preview Environment until JetBrains release a snapshot at https://www.jetbrains.com/intellij-repository/snapshots

Related Issue(s)

How to test

  1. Open the preview environment of this PR
  2. In the account preferences, select the Latest JetBrains IntelliJ IDEA as editor
  3. (...)

Release Notes

NONE

Documentation

None.

Werft options:

  • /werft with-preview

@felladrin felladrin self-assigned this Aug 19, 2022
@felladrin felladrin force-pushed the felladrin/support-for-2022.3-jetbrains-ides branch 2 times, most recently from 91d3f9b to 22ac3ef Compare August 19, 2022 10:36
@gitpod-io gitpod-io deleted a comment from werft-gitpod-dev-com bot Aug 19, 2022
@felladrin felladrin changed the title [JetBrains] Preparation for v2022.3 [jb] Preparation for v2022.3 Aug 19, 2022
# Version from "com.jetbrains.intellij.idea" which can be found at https://www.jetbrains.com/intellij-repository/snapshots
platformVersion=222.3739-EAP-CANDIDATE-SNAPSHOT
# TODO: Update to 223.2931 snapshot when it becomes available.
platformVersion=223.1192-EAP-CANDIDATE-SNAPSHOT
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Update to 223.2931+ snapshot when it becomes available.

@@ -50,7 +50,7 @@ packages:
metadata:
helm-component: workspace.desktopIdeImages.intellijLatest
buildArgs:
JETBRAINS_BACKEND_URL: "https://download.jetbrains.com/product?type=release,rc,eap&distribution=linux&code=IIU"
JETBRAINS_BACKEND_URL: "https://download-cdn.jetbrains.com/idea/gateway/idea_tmp/ideaIU-223.2931.tar.gz"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Revert this line before merging this PR.

@@ -115,6 +115,7 @@ tasks {
}

runPluginVerifier {
enabled = false // TODO: Re-enable it when there's a 2022.3 ide version released.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Re-enable it when there's a 2022.3 ide version released.

@felladrin felladrin force-pushed the felladrin/support-for-2022.3-jetbrains-ides branch from 22ac3ef to 2937828 Compare August 23, 2022 14:51
@roboquat roboquat added size/L and removed size/S labels Aug 23, 2022
@felladrin felladrin force-pushed the felladrin/support-for-2022.3-jetbrains-ides branch 2 times, most recently from a372b2b to d1bdf08 Compare August 23, 2022 17:05
Comment on lines +72 to +76
GlobalScope.launch {
withContext(Dispatchers.IO) {
CommandLineProcessor.doOpenFileOrProject(file, shouldWait).future.get()
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ This change is required by the latest IDE build because doOpenFileOrProject is now a suspend function.

@gitpod-io gitpod-io deleted a comment from werft-gitpod-dev-com bot Aug 23, 2022
@felladrin felladrin force-pushed the felladrin/support-for-2022.3-jetbrains-ides branch 2 times, most recently from 8ab0b98 to c7b6379 Compare August 24, 2022 13:38
@felladrin felladrin force-pushed the felladrin/support-for-2022.3-jetbrains-ides branch from c7b6379 to 26ccab4 Compare August 24, 2022 16:01
@felladrin felladrin changed the title [jb] Preparation for v2022.3 [jb] Port Forwarding in v2022.3 Sep 16, 2022
@stale
Copy link

stale bot commented Sep 28, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 28, 2022
@felladrin
Copy link
Contributor Author

I'm closing this because #13400 contains several changes from this PR.
Will open a new one when we have a more recent build with the new Port Forwarding API.

@felladrin felladrin closed this Sep 29, 2022
@felladrin felladrin deleted the felladrin/support-for-2022.3-jetbrains-ides branch September 29, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants