Skip to content

Sje/kots backup2 #12045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Sje/kots backup2 #12045

wants to merge 7 commits into from

Conversation

mrsimonemms
Copy link
Contributor

Description

Backup of #11971 - oh the irony

Related Issue(s)

Fixes #

How to test

Release Notes

Documentation

Werft options:

  • /werft with-preview

@roboquat
Copy link
Contributor

@mrsimonemms: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gitguardian
Copy link

gitguardian bot commented Aug 10, 2022

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
4097244 Generic High Entropy Secret 2d914cb install/installer/cmd/testdata/render/customization/output.golden View secret
4097244 Generic High Entropy Secret 8eef1dc install/installer/cmd/testdata/render/backup-labels/output.golden View secret
4097244 Generic High Entropy Secret 8eef1dc install/installer/cmd/testdata/render/customization/output.golden View secret
4097244 Generic High Entropy Secret 8eef1dc install/installer/cmd/testdata/render/external-registry/output.golden View secret
4097244 Generic High Entropy Secret 8eef1dc install/installer/cmd/testdata/render/minimal/output.golden View secret
4097244 Generic High Entropy Secret 8eef1dc install/installer/cmd/testdata/render/statefulset-customization/output.golden View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@mrsimonemms mrsimonemms deleted the sje/kots-backup2 branch August 11, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants