[installer]: refactor yq to run against arbitrary strings #11973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor
yqinto its own standalone library in the Installer.Also changes the way the
apiVersionis removed from theconfig.yamlto useyqso it's not dependent upon the regex. This is a problem when using the input as a JSON object (it's unlikely, but as YAML is a superset of JSON, it is something we should probably support).Originally I thought this was required to #9926 (it's not), but I thought it had merit so spun off to its own PR.
No changes in the rendered output prove this hasn't introduced any regressions
How to test
Install via KOTS
Release Notes
Documentation
Werft options: