Skip to content

[UBP] Add tests and functionality to the Stripe webhook handler #11921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

andrew-farries
Copy link
Contributor

Description

Do some TDD on the Stripe webhook handler.

Add tests to ensure:

  • The handler only accepts POST requests.
  • The handler only responds to "invoice.finalized" events.

Add code to the handler to make those tests pass.

Related Issue(s)

Part of #10937

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@andrew-farries andrew-farries requested a review from a team August 5, 2022 11:08
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 5, 2022
Test:
* The handler only accepts POST requests.
* The handler only responds to "invoice.finalized" events.

Add code to the handler to make those tests pass.
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@geropl geropl self-assigned this Aug 5, 2022
@roboquat roboquat merged commit c1a6f64 into main Aug 5, 2022
@roboquat roboquat deleted the af/webhook-tests branch August 5, 2022 13:12
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants