Skip to content

[server] Tie protected_secrets to ConfigCag #11765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented Aug 1, 2022

Description

This PR ties protected_secrets to a ConfigCat feature flag (on server) so that we can roll this out in production. This is the next step for #10134.

I've added the protected_secrets flag to ConfigCat and enabled it for non-prod environments.

How to test

  1. Start a workspace
  2. Observe that the workspace was started with the protected_secrets flag, and that its secrets were fed from a Kubernetes secret.
    image

Release Notes

NONE

Werft options:

  • /werft with-preview

so that we can gradually roll this out in prod
@csweichel
Copy link
Contributor Author

csweichel commented Aug 1, 2022

/werft run

👍 started the job as gitpod-build-cw-protected-secrets-ff.1
(with .werft/ from main)

@csweichel csweichel marked this pull request as ready for review August 1, 2022 11:02
@csweichel csweichel requested a review from a team August 1, 2022 11:02
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 1, 2022
@roboquat roboquat merged commit 91d6ced into main Aug 1, 2022
@roboquat roboquat deleted the cw/protected_secrets_ff branch August 1, 2022 11:11
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants