Skip to content

[installer] registry-facade: Fix render bug #11596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2022
Merged

Conversation

geropl
Copy link
Member

@geropl geropl commented Jul 23, 2022

Description

During a refactor the wrong component/version combination got introduced. The /app/ready-probe-labeler is present in the registry-facade image (cmp. here).

This sometimes results in failing Gitpod installations when registry-facade and ws-daemon are not last change within the same commit.

Related Issue(s)

Fixes #

How to test

  • check registry-facade deamonset and check it has the "registr-facade" same image just like the "registry-facade"

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@geropl geropl requested a review from a team July 23, 2022 10:02
@geropl geropl requested a review from aledbf July 23, 2022 10:02
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jul 23, 2022
@roboquat roboquat merged commit 4cc2030 into main Jul 23, 2022
@roboquat roboquat deleted the gpl/fix-regfac-render branch July 23, 2022 12:16
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants