[usage] Rename misnamed column in usage table #11353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-af-rename-misnamed-column.4 because the annotations in the pull request description changed |
geropl
reviewed
Jul 13, 2022
components/gitpod-db/src/typeorm/migration/1657722262390-RenameWorkspaceIdColumn.ts
Show resolved
Hide resolved
geropl
reviewed
Jul 13, 2022
| await queryRunner.query(`DROP TABLE \`d_b_workspace_instance_usage\``); | ||
|
|
||
| await queryRunner.query( | ||
| `CREATE TABLE \`d_b_workspace_instance_usage\` (\`instanceId\` char(36) NOT NULL, \`attributionId\` varchar(255) NOT NULL, \`startedAt\` timestamp(6) NOT NULL, \`stoppedAt\` timestamp(6) NULL, \`creditsUsed\` double NOT NULL, \`generationId\` int NOT NULL, \`deleted\` tinyint NOT NULL, INDEX \`IDX_1358af969a29fd9e0c6cabf37c\` (\`attributionId\`), INDEX \`IDX_25d77dfa246b93672c317e26ad\` (\`startedAt\`), INDEX \`IDX_e759ab5fcf57350da51fcf56bc\` (\`stoppedAt\`), PRIMARY KEY (\`instanceId\`)) ENGINE=InnoDB`, |
There was a problem hiding this comment.
Regarding indexes: We have the convention to give them human readable names, e.g. one on attributionId would be ind_attributionId, one on attributionId and creationTime ind_attributionId_creationTime.
There was a problem hiding this comment.
I've added names to the indexes and regenerated the migration.
added 2 commits
July 13, 2022 15:44
Rename the misnamed primary key `workspaceId` -> `instanceId`. Usage based billing is unreleased so just drop the table and recreate it - no data to migrate. Also add index names.
andrew-farries
force-pushed
the
af/rename-misnamed-column
branch
from
00c6e66 to
c90db68
Compare
|
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-af-rename-misnamed-column.6 |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the name of the
workspaceIdcolumn toinstanceIdin thed_b_workspace_instance_usagetable as that's what it stores.As there is no production data in this table the migration is simply to drop the table and recreate it.
/hold because this is based on #11343.
Related Issue(s)
Part of #10323
How to test
Connecting to the database in the preview env for this PR shows the table with the correct column name.
Release Notes
Documentation
Werft options: