[dashboard] Add Usage-Based feature flag and empty Billing page #10302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankeromnes
force-pushed
the
jx/usage-flag
branch
3 times, most recently
from
317f559 to
8eee3df
Compare
jankeromnes
force-pushed
the
jx/usage-flag
branch
from
8eee3df to
c16ccae
Compare
easyCZ
approved these changes
May 29, 2022
There was a problem hiding this comment.
LGTM.
One nit, I'd leave the route refactor to variables into a seperate PR, or I'd have front-loaded this PR with the refactor to make this PR a tiny bit cleaner.
That's, however, my personal approach to it and as is the PR is perfectly fine. And I'm already super happy with the first PR being a feature flag! Way to go!
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Usage-Based feature flag and empty Billing page in user settings.
Related Issue(s)
Fixes #
How to test
Plans+Team Plans, but noBillingitemBilling+Plans+Team PlansRelease Notes
Documentation