[licensor] allow invalid domain in professional license #10069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-farries
approved these changes
May 18, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, in replicated professional license, we match the domain in the license to be same as the installation domain. This was intended to avoid the re-use of license for multiple installations. But this seems to increase the on-boarding time due to the requirement to know the installation domain beforehand.
This PR removes the matching of domains in the case of replicated license.
Related Issue(s)
Fixes #9937
How to test
On a self-hosted setup, a
prodlicense created with empty domain, will still have all the features for paid license listed in theLincesepage.Release Notes
Documentation