vscode about dialog don't show insiders label

[jeanp413]

After #8783 now ideAlias is always code for insiders and stable.
We need to look for other ways to differentiate vscode insiders and stable

[andreafalzetti]

I'd be keen to pick this up, I just have a couple of questions:

• what component is actually affected by this bug?
• what's the "vscode about dialog"?

cc @jeanp413 @akosyakov

[andreafalzetti]

@akosyakov and I had a call and clarified the impact and work required.

Summary:

• The ideAlias property is part of workbench (part ofGitpod VS Code browser extension) and the misconfiguration could cause both visual and functional bugs (because we do not differentiate between code and code-latest anymore). The blast radius of the bug is not well defined.
• The agreed solution includes extending supervisor with an additional property bool ide_latest and source the ideAlias from the workspace instance configuration instead of the user's preferences (so that it's actually accurate)

I am going to start working on this issue today.

cc @jeanp413 @akosyakov

[jeanp413]

I actually was thinking about something simpler yesterday:

• Just add an additional argument quality (maybe use the version arg in build.yml) to the leeway.dockerfile so if its insiders (or latest) just update the quality attribute in package.json
• So for the nightly job we pass insiders or latest and it will generate the insiders image
• For prev env by default it will generate stable image as these images are the ones we use for updating stable
  Yes, in prev env if you select insiders it will say stable, unless you change it manually in the Dockerfile but I think that's ok as an edge case for us developers, but also is good as behavior is the same when testing an image and then pinning it as stable

[andreafalzetti]

I had a chat with @jeanp413, we agree to proceed with the approach he suggested cc @akosyakov