Handle project access for non-repository members

[gtsiolis]

Problem to solve

Users that don't have access to a repository they run into errors and empty pages when access a project in Gitpod.

Steps to reproduce

1. Create a private repository in any of the available providers
2. Add a new project in a new team in Gitpod
3. Invite a team member in the new team who does have access to the repository in the corresponding provider
4. Log in with the invited team member and try accessing the project branches or opening a workspace

Empty branches page	Error when opening a workspace

Proposal

TBD (To be discussed)

This can become more relevant as users adopt Teams & Projects and create teams with multiple projects across different providers with team members that don't necessarily have access to corresponding repositories. 💡

[jldec]

Hi @gtsiolis would you mind please adding the steps required to reproduce this issue.

[gtsiolis]

@jldec I've added steps to reproduce in the issue description to clarify. Let me know if these don't look clear enough.

[jldec]

Thanks - I suppose we could always improve the error message, but the behavior seems correct - users should not be able to see repositories through Gitpod which they cannot acces directly.

[gtsiolis]

I suppose we could always improve the error message, but the behavior seems correct

Yes, handling this with better error messages is a good way forward. since there's no much we can do about this and we most probably don't want to limit project visibility for users that are part of a team but don't have access to the actual repository. 🧀

[jldec]

Looking at the error message which is there, that seems pretty close to what we want for workspace startup.
It is consistent with GitHub's behavior of showing 404 for private repos accessed by unauthed users.
We don't want to leak more information to unauthorized users.

What might be more promising as a way to improve the UX would be to show projects which won't work for you because of auth-failures in the project list, and team members with such project auth issues in the team members list.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.