`gp await-port` doesn't work correctly when port is private

[shaal]

Bug description

While testing https://twitter.com/gtsiolis/status/1417927681946103821?s=20
(https://gitpod.io/#https://gitlab.com/gitpod-io/gitlab/)

I was seeing this message in terminal, and it took forever

Awaiting port 3000... ok
Waiting for GitLab at https://3000-yellow-guineafowl-avf4hmmy.ws-us11.gitpod.io ...................

Changing port 3000 from private to public - fixes it right away.

Steps to reproduce

1. Open https://gitpod.io/#https://gitlab.com/gitpod-io/gitlab/
2. Wait for this kind of message in terminal

Awaiting port 3000... ok
Waiting for GitLab at https://3000-yellow-guineafowl-avf4hmmy.ws-us11.gitpod.io ...................

1. Change port 3000 from private to public
2. Confirm that terminal stopped waiting

Expected behavior

gp await 3000 should work the same when ports are set to private or public.

Example repository

https://gitpod.io/#https://gitlab.com/gitpod-io/gitlab/

Anything else?

No response

[akosyakov]

Can it be related to #4922?

[csweichel]

#4922 describes the inverse behaviour. There it doesn't work when the port is public; here it doesn't work when the port is private.

[csweichel]

/schedule

[csweichel]

/assign

[csweichel]

This is not an issue with gp await-port which only polls /proc/net/tcp{6} and is completely independent of public/private ports.

Rather it's to do with the following line:

until $(curl -sNL $(gp url 3000) | grep -q "GitLab"); do printf '.'; sleep 5; done && echo ""

This line cannot succeed if port 3000 isn't public, because the request made to $(gp url 3000) is not authenticated - the owner token is missing. Hence we'll correctly reject the request.
This curl could be made to succeed if one were to send the owner token using the x-gitpod-owner-token header or as the correctly named cookie. As of now though, we don't provide easy access to the owner token from within the workspace.

It would probably be worthwhile placing this "wait until the port is available externally" functionality in gp await-port, something like gp await-port --from-outside. There we could make the correct request. WDYT?

(also, removing this from groundwork until this has become actionable again)