Skip to content

[Prebuilds] Allow use of docker during prebuilds #2428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svenefftinge opened this issue Dec 5, 2020 · 4 comments
Closed

[Prebuilds] Allow use of docker during prebuilds #2428

svenefftinge opened this issue Dec 5, 2020 · 4 comments
Labels
component: supervisor feature: prebuilds meta: stale This issue/PR is stale and will be closed soon

Comments

@svenefftinge
Copy link
Member

In order to use docker during a prebuild, we need to run docker-up which is a non terminating process.
Would be good to come up with a simple solution instead of having everyone hacking this by manually stopping the docker service when done.

@svenefftinge
Copy link
Member Author

We can generalize this to adding some sort of explicit shutdown hook, that tells gitpod the prebuild is finished.

@csweichel
Copy link
Contributor

Alternatively, we could provide a "background" task type that gets run before everything else, and gets stopped just before the workspace shuts down (after a potential future teardown hook).

@weitzman
Copy link

Looks like #2654 may have made progress here but status is not clear to me.

@stale
Copy link

stale bot commented Mar 16, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Mar 16, 2021
@stale stale bot closed this as completed Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: supervisor feature: prebuilds meta: stale This issue/PR is stale and will be closed soon
Projects
None yet
Development

No branches or pull requests

3 participants