Closed
Description
We have inconsistent log output
gp timeout show
=> Workspace timeout is set to 60 minutes.
- The user has inputted no unit of measurement so default to minutes is okay.
- Command uses present tense whereas
gp timeout show
uses past tense
gp timeout extend
=> Workspace timeout has been extended to three hours.
- Log output shows in hours, no unit of measurement has been given by the user.
- This is an inconsistent default measurement to the
gp timeout show
command - Suggestion: Deprecate entirely, e.g. Deprecate
gp timeout extend
and review timeout defaults #16083
gp timeout set 10h
=> Workspace timeout has been set to 600 minutes.
- Uses past tense whereas
gp timeout show
uses present tense - Unit of measurement passed is in hours, but returned value is in minutes.
- Requires user to do mental math to figure out whether the response is correct
- Suggestion: Print output consistent with unit given, e.g. if minutes given, show minutes, if hours, show hours.
- Suggestion: Keep all outputs printed in minutes, and only accept minutes as inputs + response values.
- Related: [gitpod-cli] Flexible Workspace Timeout -
<n>days
is not working #15945