Skip to content

[supervisor] close of closed channel panic #14014

Closed
@sagor999

Description

@sagor999

Bug description

While terminating workspace, noticed this in log output from workspace pod:

Connection closed by UNKNOWN port 65535                            
debug1: channel 0: free: server-session, nchannels 1               
Close session: user gitpod from UNKNOWN port 65535 id 0            
debug1: do_cleanup                                                 
Transferred: sent 691708, received 1028712 bytes                   
Closing connection to UNKNOWN port 65535                           
mm_request_send: write: Broken pipe                                
debug1: do_cleanup                                                 
panic: close of closed channel                                     
                                                                   
goroutine 81 [running]:                                            
github.com/gitpod-io/gitpod/supervisor/cmd.glob..func3.2()         
    github.com/gitpod-io/gitpod/supervisor/cmd/init.go:87 +0xb8    
created by github.com/gitpod-io/gitpod/supervisor/cmd.glob..func3  
    github.com/gitpod-io/gitpod/supervisor/cmd/init.go:83 +0x79e   

Seems to be this line:

close(supervisorDone)

Steps to reproduce

close workspace

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response

Metadata

Metadata

Assignees

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions