[installer]: remove jobs from the gitpod-app config map

These are deleted after 60 seconds which causes the uninstallation
script not to delete anything that comes after jobs in the
ordering, such as cron jobs.

Author: Simon Emms

installer/README.md

@@ -118,6 +118,10 @@ kubectl get configmaps gitpod-app -o jsonpath='{.data.app\.yaml}' \
 cluster. This will include `Secrets` generated from internal `Certificates`
 and `PersistentVolumeClaims`. These will need to be manually deleted.
 
+[Batch jobs](https://kubernetes.io/docs/concepts/workloads/controllers/job/) are
+not included in this ConfigMap by design. These have `ttlSecondsAfterFinished`
+defined in the spec and so will be deleted shortly after the jobs have run.
+
 # Advanced topics
 
 ## Post-processing the YAML

installer/pkg/common/display.go

@@ -5,11 +5,12 @@
 package common
 
 import (
-	corev1 "k8s.io/api/core/v1"
 	"regexp"
 	"sort"
 	"strings"
 
+	corev1 "k8s.io/api/core/v1"
+
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"sigs.k8s.io/yaml"
 )
@@ -84,7 +85,8 @@ func GenerateInstallationConfigMap(ctx *RenderContext, objects []RuntimeObject)
 
 	// Convert to a simplified object that allows us to access the objects
 	for _, c := range objects {
-		if c.Kind != "" {
+		// Jobs are excluded as they break uninstallation if they've been cleaned up
+		if c.Kind != "" && !(c.APIVersion == TypeMetaBatchJob.APIVersion && c.Kind == TypeMetaBatchJob.Kind) {
 			marshal, err := yaml.Marshal(c)
 			if err != nil {
 				return nil, err