Skip to content

Commit c009480

Browse files
jankeromnesroboquat
authored andcommitted
[dashboard] Show loading indicator when switching git providers to add a new project
1 parent 5dafe5c commit c009480

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

components/dashboard/src/projects/NewProject.tsx

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -90,27 +90,24 @@ export default function NewProject() {
9090
}
9191
(async () => {
9292
updateOrgsState();
93-
const repos = await updateReposInAccounts();
94-
const first = repos[0];
95-
if (first) {
96-
setSelectedAccount(first.account);
97-
}
98-
setLoaded(true);
93+
await updateReposInAccounts();
9994
})();
10095
}, [provider]);
10196

10297
const isGitHub = () => provider === "github.com";
10398

10499
const updateReposInAccounts = async (installationId?: string) => {
100+
setLoaded(false);
101+
setReposInAccounts([]);
105102
if (!provider) {
106103
return [];
107104
}
108105
try {
109106
const repos = await getGitpodService().server.getProviderRepositoriesForUser({ provider, hints: { installationId } });
110107
setReposInAccounts(repos);
108+
setLoaded(true);
111109
return repos;
112110
} catch (error) {
113-
setReposInAccounts([]);
114111
console.log(error);
115112
}
116113
return [];
@@ -318,7 +315,7 @@ export default function NewProject() {
318315
</>
319316
);
320317

321-
const renderEmptyState = () => (<div>
318+
const renderLoadingState = () => (<div>
322319
<div className="mt-8 border rounded-xl border-gray-100 dark:border-gray-700 flex-col">
323320
<div>
324321
<div className="px-12 py-16 text-center text-gray-500 bg-gray-50 dark:bg-gray-800 rounded-xl w-96 h-h96 flex items-center justify-center">
@@ -339,7 +336,7 @@ export default function NewProject() {
339336
}
340337

341338
if (!loaded) {
342-
return renderEmptyState();
339+
return renderLoadingState();
343340
}
344341

345342
if (showGitProviders) {

0 commit comments

Comments
 (0)