Skip to content

Commit 06d1f1a

Browse files
committed
remove debug log
1 parent b75a7a1 commit 06d1f1a

File tree

4 files changed

+0
-27
lines changed

4 files changed

+0
-27
lines changed

components/content-service/pkg/layer/provider.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,8 +233,6 @@ func (s *Provider) GetContentLayerPVC(ctx context.Context, owner, workspaceID st
233233
defer tracing.FinishSpan(span, &err)
234234
tracing.ApplyOWI(span, log.OWI(owner, workspaceID, ""))
235235

236-
log.Info("GetContentLayerPVC")
237-
238236
defer func() {
239237
// we never return a nil manifest, just maybe an empty one
240238
if manifest == nil {

components/supervisor/pkg/supervisor/supervisor.go

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,6 @@ func (s IDEKind) String() string {
150150

151151
// Run serves as main entrypoint to the supervisor.
152152
func Run(options ...RunOption) {
153-
log.Info("supervisor run")
154153
exitCode := 0
155154
defer handleExit(&exitCode)
156155

@@ -237,11 +236,9 @@ func Run(options ...RunOption) {
237236
}
238237
tokenService.provider[KindGit] = []tokenProvider{NewGitTokenProvider(gitpodService, cfg.WorkspaceConfig, notificationService)}
239238

240-
log.Info("gitpodConfigService")
241239
gitpodConfigService := config.NewConfigService(cfg.RepoRoot+"/.gitpod.yml", cstate.ContentReady(), log.Log)
242240
go gitpodConfigService.Watch(ctx)
243241

244-
log.Info("starting ports manager")
245242
portMgmt := ports.NewManager(
246243
createExposedPortsImpl(cfg, gitpodService),
247244
&ports.PollingServedPortsObserver{
@@ -252,7 +249,6 @@ func Run(options ...RunOption) {
252249
internalPorts...,
253250
)
254251

255-
log.Info("finished ports manager")
256252
if opts.RunGP {
257253
cstate.MarkContentReady(csapi.WorkspaceInitFromOther)
258254
} else {
@@ -261,8 +257,6 @@ func Run(options ...RunOption) {
261257
go analyseConfigChanges(ctx, cfg, analytics, gitpodConfigService, gitpodService)
262258
}
263259

264-
log.Info("termMux")
265-
266260
termMux := terminal.NewMux()
267261
termMuxSrv := terminal.NewMuxTerminalService(termMux)
268262
termMuxSrv.DefaultWorkdir = cfg.RepoRoot
@@ -284,8 +278,6 @@ func Run(options ...RunOption) {
284278
Gid: gitpodGID,
285279
}
286280

287-
log.Info("taskManager")
288-
289281
taskManager := newTasksManager(cfg, termMuxSrv, cstate, nil)
290282

291283
apiServices := []RegisterableService{
@@ -305,14 +297,12 @@ func Run(options ...RunOption) {
305297
}
306298
apiServices = append(apiServices, additionalServices...)
307299

308-
log.Info("installDotfiles")
309300
if !cfg.isHeadless() {
310301
// We need to checkout dotfiles first, because they may be changing the path which affects the IDE.
311302
// TODO(cw): provide better feedback if the IDE start fails because of the dotfiles (provide any feedback at all).
312303
installDotfiles(ctx, cfg, tokenService, childProcEnvvars)
313304
}
314305

315-
log.Info("ideWG")
316306
var ideWG sync.WaitGroup
317307
ideWG.Add(1)
318308
go startAndWatchIDE(ctx, cfg, &cfg.IDE, childProcEnvvars, &ideWG, cstate, ideReady, WebIDE)
@@ -1312,7 +1302,6 @@ func startSSHServer(ctx context.Context, cfg *Config, wg *sync.WaitGroup, childP
13121302
}
13131303

13141304
func startContentInit(ctx context.Context, cfg *Config, wg *sync.WaitGroup, cst ContentState) {
1315-
log.Info("starting content init")
13161305
defer wg.Done()
13171306
defer log.Info("supervisor: workspace content available")
13181307

@@ -1338,8 +1327,6 @@ func startContentInit(ctx context.Context, cfg *Config, wg *sync.WaitGroup, cst
13381327
log.Info("Detected content.json in /.workspace folder, assuming PVC feature enabled")
13391328
}
13401329

1341-
log.Infof("waiting for content.json to be available at %s", fn)
1342-
13431330
var contentFile *os.File
13441331

13451332
contentFile, err = os.Open(fn)
@@ -1354,7 +1341,6 @@ func startContentInit(ctx context.Context, cfg *Config, wg *sync.WaitGroup, cst
13541341
// TODO: rewrite using fsnotify
13551342
t := time.NewTicker(100 * time.Millisecond)
13561343
for range t.C {
1357-
log.Infof("waiting for %s to be available", fnReady)
13581344
b, err := os.ReadFile(fnReady)
13591345
if err != nil {
13601346
if !os.IsNotExist(err) {
@@ -1382,14 +1368,12 @@ func startContentInit(ctx context.Context, cfg *Config, wg *sync.WaitGroup, cst
13821368

13831369
defer contentFile.Close()
13841370

1385-
log.Info("supervisor: workspace content available")
13861371
var src csapi.WorkspaceInitSource
13871372
src, err = executor.Execute(ctx, "/workspace", contentFile, true)
13881373
if err != nil {
13891374
return
13901375
}
13911376

1392-
log.Infof("supervisor: remove %s", fn)
13931377
err = os.Remove(fn)
13941378
if os.IsNotExist(err) {
13951379
// file is gone - we're good

components/ws-manager/pkg/manager/imagespec.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import (
1515

1616
"github.com/gitpod-io/gitpod/common-go/kubernetes"
1717
wsk8s "github.com/gitpod-io/gitpod/common-go/kubernetes"
18-
"github.com/gitpod-io/gitpod/common-go/log"
1918
"github.com/gitpod-io/gitpod/common-go/tracing"
2019
csapi "github.com/gitpod-io/gitpod/content-service/api"
2120
"github.com/gitpod-io/gitpod/content-service/pkg/layer"
@@ -48,8 +47,6 @@ func (m *Manager) GetImageSpec(ctx context.Context, req *regapi.GetImageSpecRequ
4847
_, fullWorkspaceBackupEnabled := pod.Labels[fullWorkspaceBackupLabel]
4948
_, pvcFeatureEnabled := pod.Labels[pvcWorkspaceFeatureLabel]
5049

51-
log.Infof("GetImageSpec, workspace %s, pvcFeatureEnabled: %v", req.Id, pvcFeatureEnabled)
52-
5350
if fullWorkspaceBackupEnabled || pvcFeatureEnabled {
5451
owner := pod.Labels[wsk8s.OwnerLabel]
5552
workspaceID := pod.Labels[wsk8s.MetaIDLabel]

components/ws-manager/pkg/manager/manager.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -171,12 +171,6 @@ type (
171171
func (m *Manager) StartWorkspace(ctx context.Context, req *api.StartWorkspaceRequest) (res *api.StartWorkspaceResponse, err error) {
172172
startWorkspaceTime := time.Now()
173173

174-
if req.Spec.IdeImage != nil {
175-
log.Infof("Starting workspace %s with supervisor image %s", req.Id, req.Spec.IdeImage.SupervisorRef)
176-
req.Spec.IdeImage.SupervisorRef = "eu.gcr.io/gitpod-core-dev/build/supervisor:pavel-pvc-enable.5"
177-
log.Infof("Overwrote supervisor image")
178-
}
179-
180174
// We cannot use the passed context because we need to decouple the timeouts
181175
// Create a context with a high timeout value to be able to wait for scale-up events in the cluster (slow operation)
182176
// Important!!!: this timeout must be lower than https://github.com/gitpod-io/gitpod/blob/main/components/ws-manager-api/typescript/src/promisified-client.ts#L122

0 commit comments

Comments
 (0)