Skip to content

Commit b75a7a1

Browse files
committed
fix PVC
1 parent d2fdb69 commit b75a7a1

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

components/content-service/pkg/layer/provider.go

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ func (s *Provider) GetContentLayer(ctx context.Context, owner, workspaceID strin
178178
return s.getSnapshotContentLayer(ctx, gis)
179179
}
180180
if pis := initializer.GetPrebuild(); pis != nil {
181-
l, manifest, err = s.getPrebuildContentLayer(ctx, pis)
181+
l, manifest, err = s.getPrebuildContentLayer(ctx, pis, false)
182182
if err != nil {
183183
log.WithError(err).WithFields(log.OWI(owner, workspaceID, "")).Warn("cannot initialize from prebuild - falling back to Git")
184184
span.LogKV("fallback-to-git", err.Error())
@@ -305,7 +305,7 @@ func (s *Provider) GetContentLayerPVC(ctx context.Context, owner, workspaceID st
305305
l = []Layer{*layer}
306306
return l, manifest, nil
307307
}
308-
l, manifest, err = s.getPrebuildContentLayer(ctx, pis)
308+
l, manifest, err = s.getPrebuildContentLayer(ctx, pis, true)
309309
if err != nil {
310310
log.WithError(err).WithFields(log.OWI(owner, workspaceID, "")).Warn("cannot initialize from prebuild - falling back to Git")
311311
span.LogKV("fallback-to-git", err.Error())
@@ -396,9 +396,10 @@ func (s *Provider) getSnapshotContentLayer(ctx context.Context, sp *csapi.Snapsh
396396
return l, manifest, nil
397397
}
398398

399-
func (s *Provider) getPrebuildContentLayer(ctx context.Context, pb *csapi.PrebuildInitializer) (l []Layer, manifest *csapi.WorkspaceContentManifest, err error) {
399+
func (s *Provider) getPrebuildContentLayer(ctx context.Context, pb *csapi.PrebuildInitializer, isPVC bool) (l []Layer, manifest *csapi.WorkspaceContentManifest, err error) {
400400
span, ctx := tracing.FromContext(ctx, "getPrebuildContentLayer")
401401
defer tracing.FinishSpan(span, &err)
402+
span.LogKV("isPVC", isPVC)
402403

403404
segs := strings.Split(pb.Prebuild.Snapshot, "@")
404405
if len(segs) != 2 {
@@ -449,7 +450,12 @@ func (s *Provider) getPrebuildContentLayer(ctx context.Context, pb *csapi.Prebui
449450
}
450451
}
451452

452-
layer, err := contentDescriptorToLayer(cdesc)
453+
var layer *Layer
454+
if isPVC {
455+
layer, err = contentDescriptorToLayerPVC(cdesc)
456+
} else {
457+
layer, err = contentDescriptorToLayer(cdesc)
458+
}
453459
if err != nil {
454460
return nil, nil, err
455461
}

0 commit comments

Comments
 (0)