-
Notifications
You must be signed in to change notification settings - Fork 87
Suggestion: Open Chrome in a Preview Tab, with the extension loaded #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
74fa729
to
cfdeeaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gtsiolis I requested your review since I am a bit new to this repo, so I could have missed something, otherwise, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, @felladrin! 🔮
I see no reason to hold this back.
issue: I remember trying this a while ago and it worked as expected, however, I'm now getting the following error when I open the PR in Gitpod. Any thoughts why this might be happening? 💭
Thanks for the ping @filiptronicek! 🏓
Ah, probably due to a race condition. Let me adjust it. |
cfdeeaf
to
3a62596
Compare
3a62596
to
90b298c
Compare
Thanks for taking a look, @felladrin! You've probably already seen this but now while the extension is successfully installed I get this error in a new tab when I open the PR. Expected? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Tried this a couple of times and it worked fine. Sounds safe to merge since it does not alter anything to related to the browser extension itself. We can always revert if we run into any issues. Thanks @felladrin for making this change, @filiptronicek for reviewing, and @andreafalzetti for stopping by! 🚌 |
Description
This PR changes
.gitpod.yml
to start the workspace with Chrome opened in the Preview Tab, with this extension loaded. So we can test it directly inside Gitpod.I originally made this change to be able to test #54, but unfortunately, via noVNC, I was not able to trigger shortcuts (like "." to open Web IDE). That's why I decided to submit the change in a separate PR.
Related Issue(s)
None.
How to test
Open this PR on Gitpod, and you will see Chrome opened in the Preview Tab. A GitHub tab will also be opened, and you'll see the Gitpod button there.
Release Notes
Documentation
None.