Skip to content

Suggestion: Open Chrome in a Preview Tab, with the extension loaded #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Feb 7, 2022

Description

This PR changes .gitpod.yml to start the workspace with Chrome opened in the Preview Tab, with this extension loaded. So we can test it directly inside Gitpod.

screencapture-gitpodio-browserextensio-d5rmblr4pdd-ws-eu30-gitpod-io-2022-02-07-21_14_01

I originally made this change to be able to test #54, but unfortunately, via noVNC, I was not able to trigger shortcuts (like "." to open Web IDE). That's why I decided to submit the change in a separate PR.

Related Issue(s)

None.

How to test

Open this PR on Gitpod, and you will see Chrome opened in the Preview Tab. A GitHub tab will also be opened, and you'll see the Gitpod button there.

Release Notes

NONE

Documentation

None.

@felladrin felladrin force-pushed the vn/open-chrome-vnc branch 2 times, most recently from 74fa729 to cfdeeaf Compare February 10, 2022 15:42
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome sauce!

image

@filiptronicek filiptronicek added the enhancement New feature or request label Feb 11, 2022
@filiptronicek
Copy link
Member

@gtsiolis I requested your review since I am a bit new to this repo, so I could have missed something, otherwise, :shipit:!

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, @felladrin! 🔮

I see no reason to hold this back.

issue: I remember trying this a while ago and it worked as expected, however, I'm now getting the following error when I open the PR in Gitpod. Any thoughts why this might be happening? 💭

Screenshot 2022-03-09 at 2 53 22 PM (2)

Thanks for the ping @filiptronicek! 🏓

@felladrin
Copy link
Contributor Author

Ah, probably due to a race condition. Let me adjust it.

@felladrin felladrin force-pushed the vn/open-chrome-vnc branch from cfdeeaf to 3a62596 Compare March 9, 2022 13:07
@felladrin felladrin force-pushed the vn/open-chrome-vnc branch from 3a62596 to 90b298c Compare March 9, 2022 13:44
@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 9, 2022

Thanks for taking a look, @felladrin! You've probably already seen this but now while the extension is successfully installed I get this error in a new tab when I open the PR. Expected?

Screenshot 2022-03-09 at 4 16 14 PM (2)

@felladrin
Copy link
Contributor Author

felladrin commented Mar 9, 2022

I saw it happening twice before, but after refreshing the extension welcome page it worked fine.

Now I've opened this PR in a new Gitpod instance and it worked fine, so I suspect it was some temporary issue with Gitpod website.

image

Copy link
Contributor

@andreafalzetti andreafalzetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@gtsiolis
Copy link
Contributor

Tried this a couple of times and it worked fine. Sounds safe to merge since it does not alter anything to related to the browser extension itself. We can always revert if we run into any issues.

Thanks @felladrin for making this change, @filiptronicek for reviewing, and @andreafalzetti for stopping by! 🚌

@gtsiolis gtsiolis merged commit bcf7e96 into master Mar 14, 2022
@felladrin felladrin deleted the vn/open-chrome-vnc branch March 14, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants