-
Notifications
You must be signed in to change notification settings - Fork 473
Added missing attributes for webhook events #1240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jmini
merged 3 commits into
gitlab4j:main
from
yarisvt:webhook-events-missing-attributes
Apr 22, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
161 changes: 161 additions & 0 deletions
161
gitlab4j-models/src/main/java/org/gitlab4j/api/models/Build.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,161 @@ | ||
package org.gitlab4j.api.models; | ||
|
||
import java.util.Date; | ||
|
||
import org.gitlab4j.models.utils.JacksonJson; | ||
|
||
/** | ||
* @author Yaris van Thiel | ||
*/ | ||
public class Build { | ||
|
||
private Long id; | ||
private String stage; | ||
private String name; | ||
private BuildStatus status; | ||
private Date createdAt; | ||
private Date startedAt; | ||
private Date finishedAt; | ||
private Float duration; | ||
private Float queuedDuration; | ||
private String failureReason; | ||
private String when; | ||
private Boolean manual; | ||
private Boolean allowFailure; | ||
private User user; | ||
private Runner runner; | ||
private ArtifactsFile artifactsFile; | ||
|
||
public Long getId() { | ||
return id; | ||
} | ||
|
||
public void setId(Long id) { | ||
this.id = id; | ||
} | ||
|
||
public String getStage() { | ||
return stage; | ||
} | ||
|
||
public void setStage(String stage) { | ||
this.stage = stage; | ||
} | ||
|
||
public String getName() { | ||
return name; | ||
} | ||
|
||
public void setName(String name) { | ||
this.name = name; | ||
} | ||
|
||
public BuildStatus getStatus() { | ||
return status; | ||
} | ||
|
||
public void setStatus(BuildStatus status) { | ||
this.status = status; | ||
} | ||
|
||
public Date getCreatedAt() { | ||
return createdAt; | ||
} | ||
|
||
public void setCreatedAt(Date createdAt) { | ||
this.createdAt = createdAt; | ||
} | ||
|
||
public Date getStartedAt() { | ||
return startedAt; | ||
} | ||
|
||
public void setStartedAt(Date startedAt) { | ||
this.startedAt = startedAt; | ||
} | ||
|
||
public Date getFinishedAt() { | ||
return finishedAt; | ||
} | ||
|
||
public void setFinishedAt(Date finishedAt) { | ||
this.finishedAt = finishedAt; | ||
} | ||
|
||
public Float getDuration() { | ||
return duration; | ||
} | ||
|
||
public void setDuration(Float duration) { | ||
this.duration = duration; | ||
} | ||
|
||
public Float getQueuedDuration() { | ||
return queuedDuration; | ||
} | ||
|
||
public void setQueuedDuration(Float queuedDuration) { | ||
this.queuedDuration = queuedDuration; | ||
} | ||
|
||
public String getFailureReason() { | ||
return failureReason; | ||
} | ||
|
||
public void setFailureReason(String failureReason) { | ||
this.failureReason = failureReason; | ||
} | ||
|
||
public String getWhen() { | ||
return when; | ||
} | ||
|
||
public void setWhen(String when) { | ||
this.when = when; | ||
} | ||
|
||
public Boolean getManual() { | ||
return manual; | ||
} | ||
|
||
public void setManual(Boolean manual) { | ||
this.manual = manual; | ||
} | ||
|
||
public Boolean getAllowFailure() { | ||
return allowFailure; | ||
} | ||
|
||
public void setAllowFailure(Boolean allowFailure) { | ||
this.allowFailure = allowFailure; | ||
} | ||
|
||
public User getUser() { | ||
return user; | ||
} | ||
|
||
public void setUser(User user) { | ||
this.user = user; | ||
} | ||
|
||
public Runner getRunner() { | ||
return runner; | ||
} | ||
|
||
public void setRunner(Runner runner) { | ||
this.runner = runner; | ||
} | ||
|
||
public ArtifactsFile getArtifactsFile() { | ||
return artifactsFile; | ||
} | ||
|
||
public void setArtifactsFile(ArtifactsFile artifactsFile) { | ||
this.artifactsFile = artifactsFile; | ||
} | ||
|
||
@Override | ||
public String toString() { | ||
return (JacksonJson.toJsonString(this)); | ||
} | ||
} |
60 changes: 60 additions & 0 deletions
60
gitlab4j-models/src/main/java/org/gitlab4j/api/models/BuildStatus.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
/* | ||
* The MIT License (MIT) | ||
* | ||
* Copyright (c) 2017 Greg Messner <[email protected]> | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy of | ||
* this software and associated documentation files (the "Software"), to deal in | ||
* the Software without restriction, including without limitation the rights to | ||
* use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of | ||
* the Software, and to permit persons to whom the Software is furnished to do so, | ||
* subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included in all | ||
* copies or substantial portions of the Software. | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS | ||
* FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR | ||
* COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER | ||
* IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN | ||
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
*/ | ||
|
||
package org.gitlab4j.api.models; | ||
|
||
import org.gitlab4j.models.utils.JacksonJsonEnumHelper; | ||
|
||
import com.fasterxml.jackson.annotation.JsonCreator; | ||
import com.fasterxml.jackson.annotation.JsonValue; | ||
|
||
/** | ||
* Enum for the various Build status values. | ||
*/ | ||
public enum BuildStatus { | ||
CREATED, | ||
RUNNING, | ||
PENDING, | ||
SUCCESS, | ||
FAILED, | ||
CANCELED, | ||
SKIPPED, | ||
MANUAL; | ||
|
||
private static JacksonJsonEnumHelper<BuildStatus> enumHelper = new JacksonJsonEnumHelper<>(BuildStatus.class); | ||
|
||
@JsonCreator | ||
public static BuildStatus forValue(String value) { | ||
return enumHelper.forValue(value); | ||
} | ||
|
||
@JsonValue | ||
public String toValue() { | ||
return (enumHelper.toString(this)); | ||
} | ||
|
||
@Override | ||
public String toString() { | ||
return (enumHelper.toString(this)); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if this is not a duplication of the enum
Constants.JobScope
that we already have.But
BuildStatus
seems a better name and feels more natural.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually copied
JobStatus
intoBuildStatus
, they're the same except for the name. But I figured it's more clear to distinguish between jobs and builds