Skip to content

Bump fsnotify to bump sys for go1.18 #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ypresto
Copy link

@ypresto ypresto commented Apr 6, 2022

I'm using go 1.18 on macOS, and go install fails with below message:

$ go install github.com/githubnemo/CompileDaemon@latest
# golang.org/x/sys/unix
../../go/1.18.0/pkg/mod/golang.org/x/[email protected]/unix/syscall_darwin.1_13.go:25:3: //go:linkname must refer to declared function or variable
../../go/1.18.0/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.1_13.go:27:3: //go:linkname must refer to declared function or variable
../../go/1.18.0/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.1_13.go:40:3: //go:linkname must refer to declared function or variable
../../go/1.18.0/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:28:3: //go:linkname must refer to declared function or variable
../../go/1.18.0/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:43:3: //go:linkname must refer to declared function or variable
../../go/1.18.0/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:59:3: //go:linkname must refer to declared function or variable
../../go/1.18.0/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:75:3: //go:linkname must refer to declared function or variable
../../go/1.18.0/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:90:3: //go:linkname must refer to declared function or variable
../../go/1.18.0/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:105:3: //go:linkname must refer to declared function or variable
../../go/1.18.0/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:121:3: //go:linkname must refer to declared function or variable
../../go/1.18.0/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:121:3: too many errors

This is caused by old x/sys library.

Using depth dependency tree visualizer, I found old fsnotify module references old x/sys module.

So just I bumped it :)

@sylr
Copy link

sylr commented Apr 7, 2022

https://github.com/bwplotka/bingo test suite on MacOS / go1.18 does not work anymore because of this.

We would appreciate if this could be merged and released promptly :)

Thanks.

Needed for bwplotka/bingo#109

@jeffreydwalter
Copy link

@githubnemo can you please merge this?

@ypresto
Copy link
Author

ypresto commented Jun 27, 2022

I created fork at https://github.com/ypresto/CompileDaemon/tree/bump-sys .
You can install it by below snippet:

go get github.com/ypresto/CompileDaemon@bump-sys-fork

@nhatthm
Copy link

nhatthm commented Sep 8, 2022

Bump.

@patrickvalle
Copy link

@githubnemo Any chance this can get merged soon?

@githubnemo
Copy link
Owner

Should be fixed now. Feel free to re-open.

@githubnemo githubnemo closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants