Skip to content

Update for modern browsers #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ Browsers without native [custom element support][support] require a [polyfill][]
- Chrome
- Firefox
- Safari
- Internet Explorer 11
- Microsoft Edge

[support]: https://caniuse.com/#feat=custom-elementsv1
Expand Down
444 changes: 160 additions & 284 deletions package-lock.json

Large diffs are not rendered by default.

13 changes: 7 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"module": "dist/index.esm.js",
"scripts": {
"clean": "rm -rf dist",
"lint": "eslint src/ test/ && flow check",
"lint": "eslint . && flow check",
"prebuild": "npm run clean && npm run lint",
"build": "rollup -c && cp src/task-lists-element.js.flow dist/index.esm.js.flow && cp src/task-lists-element.js.flow dist/index.umd.js.flow",
"pretest": "npm run build",
Expand All @@ -24,12 +24,10 @@
],
"devDependencies": {
"@babel/core": "^7.2.2",
"@babel/preset-env": "^7.2.3",
"@babel/preset-flow": "^7.0.0",
"babel-plugin-transform-custom-element-classes": "^0.1.0",
"babel-preset-github": "^2.1.1",
"chai": "^4.2.0",
"eslint": "^5.12.0",
"eslint-plugin-github": "^1.6.1",
"eslint-plugin-github": "^1.9.0",
"flow-bin": "^0.92.1",
"karma": "^4.0.0",
"karma-chai": "^0.1.0",
Expand All @@ -39,5 +37,8 @@
"mocha": "^5.2.0",
"rollup": "^1.0.2",
"rollup-plugin-babel": "^4.2.0"
}
},
"eslintIgnore": [
"dist/"
]
}
3 changes: 1 addition & 2 deletions rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ export default {
],
plugins: [
babel({
plugins: ['transform-custom-element-classes'],
presets: ['@babel/env', '@babel/flow']
presets: ['github']
})
]
}
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* @flow */
/* @flow strict */

import TaskListsElement from './task-lists-element'
export {TaskListsElement as default}
Expand Down
2 changes: 1 addition & 1 deletion src/sortable.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* @flow */
/* @flow strict */

type SortStartHandler = (srcList: Element) => mixed
type SortEndHandler = ({
Expand Down
2 changes: 1 addition & 1 deletion src/task-lists-element.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* @flow */
/* @flow strict */

import {isDragging, sortable} from './sortable'

Expand Down
2 changes: 1 addition & 1 deletion src/task-lists-element.js.flow
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* @flow */
/* @flow strict */

declare class TaskListsElement extends HTMLElement {
get disabled(): boolean;
Expand Down