Merge pull request #110 from github/kh-except-link-tag

Don't flag `title` on link tag

Author: khiga8

docs/rules/accessibility/no-title-attribute.md

@@ -2,7 +2,7 @@
 
 ## Rule Details
 
-The `title` attribute is strongly discouraged. The only exception is on an `<iframe>` element. It is hardly useful and cannot be accessed by multiple groups of users including keyboard-only users and mobile users.
+The `title` attribute is strongly discouraged. The only exceptions are for `<link>` and `<iframe>` element. It is hardly useful and cannot be accessed by multiple groups of users including keyboard-only users and mobile users.
 
 The `title` attribute is commonly seen set on links, matching the link text. This is redundant and unnecessary so it can be simply be removed.
 

lib/erblint-github/linters/github/accessibility/no_title_attribute.rb

@@ -10,11 +10,11 @@ class NoTitleAttribute < Linter
           include ERBLint::Linters::CustomHelpers
           include LinterRegistry
 
-          MESSAGE = "The title attribute should never be used unless for an `<iframe>` as it is inaccessible for several groups of users."
+          MESSAGE = "The title attribute should never be used as it is inaccessible for several groups of users. Exceptions are provided for <iframe> and <link>."
 
           def run(processed_source)
             tags(processed_source).each do |tag|
-              next if tag.name == "iframe"
+              next if tag.name == "iframe" || tag.name == "link"
               next if tag.closing?
 
               title = possible_attribute_values(tag, "title")

test/linters/accessibility/no_title_attribute_test.rb

@@ -13,7 +13,7 @@ def test_warns_if_element_sets_title
 
     assert_equal(1, @linter.offenses.count)
     error_messages = @linter.offenses.map(&:message).sort
-    assert_match(/The title attribute should never be used unless for an `<iframe>` as it is inaccessible for several groups of users./, error_messages.last)
+    assert_match(/The title attribute should never be used as it is inaccessible for several groups of users./, error_messages.last)
   end
 
   def test_does_not_warn_if_iframe_sets_title
@@ -22,4 +22,11 @@ def test_does_not_warn_if_iframe_sets_title
 
     assert_empty @linter.offenses
   end
+
+  def test_does_not_warn_if_link_sets_title
+    @file = "<link rel='unapi-server' type='application/xml' title='unAPI' href='/unapi'/></link>"
+    @linter.run(processed_source)
+
+    assert_empty @linter.offenses
+  end
 end