Skip to content

repo sync #8233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 14, 2021
Merged

repo sync #8233

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
defa1b1
prevent scroll to top when URL fragment exists (#20326)
rachmari Jul 14, 2021
5ca188e
Merge branch 'main' into repo-sync
Octomerger Jul 14, 2021
a847d36
Merge pull request #20353 from github/repo-sync
Octomerger Jul 14, 2021
d3be242
Merge branch 'main' into repo-sync
Octomerger Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions components/product/SidebarProduct.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@ export const SidebarProduct = () => {
// Setting to the top doesn't give enough context of surrounding categories
activeArticle?.scrollIntoView({ block: 'center' })
// scrollIntoView affects some articles that are very low in the sidebar
// The content scrolls down a bit. This sets the article content back up top
window?.scrollTo(0, 0)
// The content scrolls down a bit. This sets the article content back up
// top unless the route contains a link heading.
if (!router.asPath.includes('#')) window?.scrollTo(0, 0)
}, [])

if (!currentProductTree) {
Expand Down