-
Notifications
You must be signed in to change notification settings - Fork 62.2k
Changed the term master to main #722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since we are updating it everywhere :)
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Thanks so much for the PR @pr0PM! I'll get this triaged for review 🌟 |
description: >- | ||
The default development branch. Whenever you create a Git repository, a | ||
branch named "master" is created, and becomes the active branch. In most | ||
branch named "main" is created, and becomes the active branch. In most |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever you create a Git repository, a branch named "master" is created
Unfortunately this isn't true. If you create a directory, go into it, and do git init
to create a new repository, in most cases you'll find yourself in a branch called master
- unless you have configured a git template that changes this to something else, like main
.
I'd suggest we simplify the definition of main
here to just:
Typically, the default branch for repositories on GitHub is called
main
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So shall I make a commit with proposal to add separate definition of main
in the glossary as suggested by you, keeping the definition of master
intact since it's the current standard in Git?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I think you're right: we shouldn't do away with master
in the glossary all together. Could you commit another change that alters the definition for main
and adds an entry for master
. I think we should simplify the definition of master
and indicate that it's not a term used at GitHub. How about:
- term: master
description: >-
The default branch in many Git repositories. By default, when you create a new Git repository on the command line a branch called `master` is created. Many tools now use an alternative name for the default branch. For example, when you create a new repository on GitHub the default branch is called `main`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing this pull request. We should definitely update the glossary to use main
. I've suggested a change to the definition for main
.
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
Added description for master along with main, since master is still the default on git itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pr0PM - thanks. I'll merge this now.
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
Since we are updating it everywhere :)
Why: master -> main
What's being changed: Glossary
The glossary section has been updated in all the relevant places that came under my eyes while reading it.
Check off the following: