Skip to content

Fail when creating PR #3187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2021
Merged

Fail when creating PR #3187

merged 2 commits into from
Feb 10, 2021

Conversation

sayanarijit
Copy link
Contributor

Why:

To improve the doc for creating PR from GH actions.

What's being changed:

Add --fail to exit with non-zero return code when curl fails to create a PR.

Check off the following:

@welcome
Copy link

welcome bot commented Jan 26, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

sayanarijit
sayanarijit commented Jan 26, 2021
View reviewed changes
@sayanarijit
Fail when creating PR
7fa31d3 
Add `--fail` to exit with non-zero return code when `curl` fails to create a PR.
@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Jan 26, 2021
@janiceilene
Copy link
Contributor

@sayanarijit Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added the waiting for review Issue/PR is waiting for a writer's review label Feb 5, 2021
@lucascosti lucascosti self-assigned this Feb 10, 2021
lucascosti
lucascosti approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great! Thanks for this contribution, I'll merge it in

@lucascosti lucascosti enabled auto-merge (squash) February 10, 2021 03:48
@lucascosti lucascosti merged commit c717883 into github:main Feb 10, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Dmarch28 pushed a commit to Dmarch28/docs that referenced this pull request Mar 4, 2021
@sayanarijit @Dmarch28
Add --fail to exit with non-zero return code when curl fails to c…
2c8416e 
…reate a PR. (github#3187)
Dmarch28 pushed a commit to Provider-of-Algorithms/docs that referenced this pull request Mar 7, 2021
@sayanarijit @Dmarch28
Add --fail to exit with non-zero return code when curl fails to c…
ce5d7b9 
…reate a PR. (github#3187)
Dmarch28 pushed a commit to Provider-of-Algorithms/docs that referenced this pull request Mar 7, 2021
@sayanarijit @Dmarch28
Add --fail to exit with non-zero return code when curl fails to c…
07983a6 
…reate a PR. (github#3187)
@snyk-bot snyk-bot mentioned this pull request May 15, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jun 1, 2023
Open
@311821105 311821105 mentioned this pull request Jun 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucascosti lucascosti lucascosti approved these changes

Assignees

@lucascosti lucascosti

Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sayanarijit @janiceilene @lucascosti