Skip to content

updating doc with links for licenses #3044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 3, 2021
Merged

Conversation

Moose0621
Copy link
Contributor

@Moose0621 Moose0621 commented Jan 21, 2021

The experiance for new users is not very obvious as to where they will receive their license. I've included links for Download and Install to help the user find the information. I will be adding another commit when I have fleshed out the various ways that users get the GHES license.

Why: As a Field Solution Engineer, our customers are having trouble figuring out where they can download their GHES licenses.

What's being changed: I am including some hyperlinks to our download, and install documentation for GHES, as well as a sentence around where they might be able to find their licenses depending on their situation.

Check off the following:

The experiance for new users is not very obvious as to `where` they will receive their license. I've included links for Download and Install to help the user find the information.  I will be adding another commit when I have fleshed out the various ways that users get the GHES license.
@welcome
Copy link

welcome bot commented Jan 21, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

Thanks for opening a PR @Moose0621! Let me know when you're ready for a writer review ✨

@Moose0621
Copy link
Contributor Author

Thanks for opening a PR @Moose0621! Let me know when you're ready for a writer review ✨

@janiceilene I'm ready and could use some help, I updated the PR Comments as to the Why and What changed and looking forward to feedback around this!

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Jan 21, 2021
@janiceilene janiceilene added the waiting for review Issue/PR is waiting for a writer's review label Feb 5, 2021
@github-actions github-actions bot closed this Feb 16, 2021
@janiceilene
Copy link
Contributor

It looks like our new action inadvertently closed this 🙃 Sorry about that! Reopening and triaging this for review 💛

@janiceilene janiceilene reopened this Feb 17, 2021
@github-actions github-actions bot removed the waiting for review Issue/PR is waiting for a writer's review label Feb 17, 2021
@chiedo chiedo added the waiting for review Issue/PR is waiting for a writer's review label Feb 17, 2021
@mchammer01 mchammer01 self-assigned this Mar 3, 2021
@mchammer01 mchammer01 marked this pull request as ready for review March 3, 2021 16:06
@mchammer01
Copy link
Contributor

Thanks for raising this PR @Moose0621 - I've made a few small tweaks, and will merge this once the checks have passed ✨

@janiceilene janiceilene added the ready to merge This pull request is ready to merge label Mar 3, 2021
@megbird megbird enabled auto-merge March 3, 2021 21:47
Copy link
Contributor

@megbird megbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick fix and merging now ⚡ Thank you @Moose0621 for opening this up 😄

@megbird megbird merged commit 862179d into main Mar 3, 2021
@megbird megbird deleted the license-update-instruction branch March 3, 2021 22:11
@Realest1Re Realest1Re mentioned this pull request Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants