Skip to content

docs: Add notes about runs-on syntax #29641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

gonmmarques
Copy link
Contributor

@gonmmarques gonmmarques commented Nov 1, 2023

Why:

This PR clarifies the need for quotes around expressions on runs-on on the workflow jobs

Closes: #20495

What's being changed (if available, include any code snippets, screenshots, or gifs):

Following this #20495 (comment)

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 1, 2023
@cmwilson21
Copy link
Contributor

@gonmmarques Thanks so much for submitting a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review actions This issue or pull request should be reviewed by the docs actions team and removed triage Do not begin working on this issue until triaged by the team labels Nov 1, 2023
lecoursen
lecoursen previously approved these changes Nov 1, 2023
Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gonmmarques, I'll get this merged! ⚡

@lecoursen lecoursen added this pull request to the merge queue Nov 1, 2023
Merged via the queue into github:main with commit 1e14d68 Nov 1, 2023
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@gonmmarques gonmmarques deleted the docs/syntax-runs-on branch November 1, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fromJSON should include an example of an array for runs-on
3 participants