-
Notifications
You must be signed in to change notification settings - Fork 62k
Update example to use env. within expression #26654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The example as-is did not work for me on ubuntu-latest. This syntax worked. I received an "Invalid workflow file" error.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@kaylareopelle Thank you for opening a PR and linking it to your issue! And welcome to the community! ✨ And thanks for the extra context in the details in the issue. I'll get this triaged for review ⚡ In the meantime, if you'd like to find other ways to contribute, check out our help wanted section to find open issues you can work on. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaylareopelle - Many thanks for submitting this PR. Seems like the current docs here need some rework, but I don't think we should change this section to use the env
context. See my comment on the issue, and my suggestions on this PR.
If you're okay with my suggested changes we can get this merged/published.
Thanks again for taking the time to raise the issue and this PR. 🙇
Hi @hubwriter thanks for the suggested changes. I'm away on vacation this week and would prefer to pick this up again when I'm back. Could we reconvene next week? |
Note to self 😄 |
@kaylareopelle - Hi 👋 |
Co-authored-by: hubwriter <[email protected]>
Hi @hubwriter, thanks for the reminder about this. I've committed your suggestions. I have a few other changes I'd like to propose as part of this PR and will commit them soon. |
Ok, @hubwriter! I've added my changes. I'm also open to feedback on my commit messages and the number of commits. I looked for documentation about how GitHub docs prefer to have commits written, but couldn't find an answer. |
@kaylareopelle - Thank you for doing more work on this. However, your changes seem to say that I've asked for some expert eyes on this, so that we can make sure the wording is accurate. Clearly this isn't explained well enough in the docs right now so it would be good to improve this article. I'll return to this once I've had advice from an SME. |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
Thanks, @hubwriter! I appreciate you sticking with me on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaylareopelle - After getting some advice on this from the development team, I've suggested a few further changes. These are just a slight adjustment in emphasis to your previous changes.
Thank you for your patience. If you are happy with these suggestions, please just click "Commit suggestion" for them and I'll get this PR merged.
@kaylareopelle - just bumping my previous message: #26654 (review) If I don't hear from you to the contrary I'll apply those suggested changes so that we can get this merged. |
Co-authored-by: hubwriter <[email protected]>
Hi @hubwriter, thanks for your patience and for these updates. I think everything seems much clearer, though I'm not quite sure what the phrase "referenced actions" means in two of the updates. Can you clarify? |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
The example as-is did not work for me on ubuntu-latest. This syntax worked. I received an "Invalid workflow file" error. See issue #26653 for details.
Closes: #26653
What's being changed (if available, include any code snippets, screenshots, or gifs):
Changing the example from using
$ENVIRONMENT_VARIABLE
toenv.ENVIRONMENT_VARIABLE
.Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
data
directory.For content changes, I have completed the self-review checklist.