Skip to content

Update securing-your-github-pages-site-with-https.md #26373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 14, 2023
Merged

Update securing-your-github-pages-site-with-https.md #26373

merged 3 commits into from
Jul 14, 2023

Conversation

evK1
Copy link
Contributor

@evK1 evK1 commented Jun 30, 2023

Added note that Pages site must be public to obtain LE cert. Customer had an issue with this recently and it seems a fairly big oversight not to mention.

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@evK1
Update securing-your-github-pages-site-with-https.md
95c6bcd 
Added note that Pages site must be public to obtain LE cert. Customer had an issue with this recently and it seems a fairly big oversight not to mention.
@welcome
Copy link

welcome bot commented Jun 30, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
pages/getting-started-with-github-pages/securing-your-github-pages-site-with-https.md fpt
ghec
 fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

👋 @evK1 - Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review pages Content related to GitHub Pages and removed triage Do not begin working on this issue until triaged by the team labels Jun 30, 2023
sophietheking
sophietheking previously approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@sophietheking sophietheking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one suggestion to add a variable instead of the product name, but this change looks good to me. Thanks for adding this to our Docs!

Feel free to @mention me here to get this merged. ✨

evK1 and others added 2 commits July 12, 2023 17:12
@evK1
Copy link
Contributor Author

evK1 commented Jul 12, 2023

Left one suggestion to add a variable instead of the product name, but this change looks good to me. Thanks for adding this to our Docs!

Feel free to @mention me here to get this merged. ✨

@sophietheking - merge away ma'am :)

@sophietheking sophietheking added this pull request to the merge queue Jul 14, 2023
Merged via the queue into github:main with commit aeba6bd Jul 14, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@evK1 evK1 deleted the patch-1 branch July 25, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophietheking sophietheking sophietheking approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team pages Content related to GitHub Pages waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evK1 @cmwilson21 @sophietheking