Skip to content

remove translations/*/content/README.md #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

shogo82148
Copy link
Contributor

Why:

Some translated documents have content/README.md (but not all).
These files are ignored by crowdin.yml, so they are never updated by the Crowdin integration.

"/content/README.md"

I think that these files were committed by mistake.
They confuse us because they keep holding on to old information.

What's being changed:

I removed them.

Check off the following:

@shogo82148 shogo82148 requested a review from a team as a code owner October 8, 2020 09:33
@welcome
Copy link

welcome bot commented Oct 8, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@zeke zeke added engineering Will involve Docs Engineering localization Issue or PR relating to translation or localization labels Oct 8, 2020
Copy link
Contributor

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @shogo82148. Those README files are supposed to by ignored by our Crowdin integration but it looks like they slipped through the cracks at some point.

I'll merge this when all checks are passing.

@zeke zeke merged commit 6cebc9a into github:main Oct 8, 2020
@shogo82148 shogo82148 deleted the remove-translations-content-readme branch October 9, 2020 01:20
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
* Fix link

* Add space

Co-authored-by: Lana Brindley <[email protected]>

Co-authored-by: Lana Brindley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Will involve Docs Engineering localization Issue or PR relating to translation or localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants