Skip to content

Add link to context availability for workflow .if key syntax #22437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 6, 2022

Conversation

MarkIannucci
Copy link
Contributor

@MarkIannucci MarkIannucci commented Dec 3, 2022

Why:

Closes #22436

What's being changed (if available, include any code snippets, screenshots, or gifs):

image

Check off the following:

@welcome
Copy link

welcome bot commented Dec 3, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 3, 2022
@cmwilson21
Copy link
Contributor

@MarkIannucci Thank you for opening a PR and linking it to your issue! ✨

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Dec 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/workflow-syntax-for-github-actions.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @MarkIannucci! I've pushed up a change that adds a link to the context availability article for all the mention of .if keys.

Almost all keys are somewhat restricted in their use of certain contexts, but it is more obvious when using them for conditions in the .if keys, so I think a regular sentence will suffice here.

Thanks for the contribution, I'll get this merged.

@lucascosti lucascosti changed the title callout missing job and matrix functionality in if conditional Add link to context availability for workflow .if key syntax Dec 6, 2022
@lucascosti lucascosti enabled auto-merge (squash) December 6, 2022 05:45
@lucascosti lucascosti merged commit b110dac into github:main Dec 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@MarkIannucci
Copy link
Contributor Author

I like how you toned down my frustration. I also saw some nice practices in the way the docs team is using actions to deliver the docs site. I definitely feel that I learned more than I gave with this PR. Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add callout that some contexts aren't available for use in the jobs.<job_id>.if conditional
3 participants