Skip to content

Add default branch note to workflow_run event #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2020

Conversation

lucascosti
Copy link
Contributor

@lucascosti lucascosti commented Dec 14, 2020

Why:

Fixes: #799

What's being changed:

This adds the default branch note to the workflow_run event description. workflow_run triggered workflows only occur if the workflow file is on the default branch.

Preview: https://docs-2062--lucascostiworkflow.herokuapp.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#workflow_run

Check off the following:

  • All of the tests are passing. The failing check is a buggy one, and has been reported to engineering.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

Copy link
Contributor

@martin389 martin389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@lucascosti lucascosti merged commit 470e3da into main Dec 14, 2020
@lucascosti lucascosti deleted the lucascosti/workflow_run_note branch December 14, 2020 05:37
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@alexpapworth
Copy link

Hi Lucas. The amended doc is looking great. Thanks for your help!

https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#workflow_run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions: add more details for "workflow_run" event
3 participants