Skip to content

Update gmail-buttons.png #20326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 7, 2022
Merged

Conversation

aisgbnok
Copy link
Contributor

Why:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Updating the gmail-buttons.png to reflect current look of Gmail and show more buttons.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 31, 2022
@aisgbnok
Copy link
Contributor Author

aisgbnok commented Aug 31, 2022

Should I update this:

If you're using Gmail, you can click a button beside the notification email to visit the original issue or pull request that generated the notification.

To say something like: "..to visit the original issue, pull request, release, or commit that generated..."?

This might not be needed which is why I didn't commit it yet. I don't know the entire list of buttons, but there are probably more for discussions, actions, etc.

@cmwilson21
Copy link
Contributor

@aisgbnok Thanks for submitting a PR and linking it to your issue! 💖

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review notifications Content related to notifications account-and-profile Content relating to account and profile and removed triage Do not begin working on this issue until triaged by the team labels Sep 1, 2022
Copy link

@PIYUSH-MISHRA-00 PIYUSH-MISHRA-00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a more clear and bigger image for better understanding

Copy link

@Abhinavkar Abhinavkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@cmwilson21 cmwilson21 added the ready to merge This pull request is ready to merge label Sep 6, 2022
Copy link
Contributor

@cmwilson21 cmwilson21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@cmwilson21
Copy link
Contributor

@aisgbnok Thanks for updating this image. I appreciate you taking the time to make sure this one is very clear while blurring out the personal emails. Regarding your other question, I think the wording still communicates what a user can expect to find, so we'll leave that as is for now. 🎉

Thanks again for your interest and passion for improving GitHub docs! 💖

@cmwilson21 cmwilson21 merged commit 07a2cfc into github:main Sep 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@aisgbnok aisgbnok deleted the update-gmail-buttons branch September 7, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
account-and-profile Content relating to account and profile content This issue or pull request belongs to the Docs Content team notifications Content related to notifications ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Gmail buttons screenshot
4 participants