Skip to content

Typo: make container name consistent #17600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 24, 2022
Merged

Typo: make container name consistent #17600

merged 4 commits into from
May 24, 2022

Conversation

blue-jam
Copy link
Contributor

@blue-jam blue-jam commented May 4, 2022 •
edited
Loading

Why:

Fixing typo. Example container image names IMAGE_NAME and IMAGE-NAME are mixed on the page. This PR replaces the hyphen version with the underscore version to make them consistent.

What's being changed:

Replaced IMAGE-NAME (all capital ones) with IMAGE_NAME on this page.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented May 4, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 4, 2022
@blue-jam blue-jam mentioned this pull request May 4, 2022
Closed
5 tasks
@blue-jam
Copy link
Contributor Author

blue-jam commented May 4, 2022

There is one failing check "filterContentDir". As far as I read a log from the action, it seems the action tried to get diff between main and patch-2 in github/docs (https://api.github.com/repos/github/docs/compare/main...patch-2 ) rather than one between main and patch-2 in my forked repository (https://api.github.com/repos/github/docs/compare/main...blue-jam:patch-2 ).

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team packages This issue or pull request should be reviewed by the docs packages team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels May 4, 2022
@ramyaparimi
Copy link
Contributor

@blue-jam
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
packages/working-with-a-github-packages-registry/working-with-the-container-registry.md fpt
ghec
ghes
 fpt
ghec
ghes

skedwards88
skedwards88 previously approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix! We'll get this merged down for you.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label May 23, 2022
skedwards88
skedwards88 approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving after resolving merge conflict

@janiceilene janiceilene merged commit 10bf8fb into github:main May 24, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@blue-jam blue-jam deleted the patch-2 branch June 5, 2022 11:37
SoeAung95
SoeAung95 reviewed Jan 2, 2025
View reviewed changes
Copy link

@SoeAung95 SoeAung95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gh run list
gh run view --log

content/packages/working-with-a-github-packages-registry/working-with-the-container-registry.md
```shell
$ docker push {% data reusables.package_registry.container-registry-hostname %}/OWNER/IMAGE_NAME:latest
```

This example pushes the `2.5` version of the image.
```shell
$ docker push {% data reusables.package_registry.container-registry-hostname %}/OWNER/IMAGE-NAME:2.5
$ docker push {% data reusables.package_registry.container-registry-hostname %}/OWNER/IMAGE_NAME:2.5
```

When you first publish a package, the default visibility is private. To change the visibility or set access permissions, see "[Configuring a package's access control and visibility](/packages/learn-github-packages/configuring-a-packages-access-control-and-visibility)."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gh run list
gh run view --log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoeAung95 SoeAung95 SoeAung95 left review comments

@skedwards88 skedwards88 skedwards88 approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team packages This issue or pull request should be reviewed by the docs packages team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@blue-jam @ramyaparimi @skedwards88 @SoeAung95 @janiceilene @hectorsector