-
Notifications
You must be signed in to change notification settings - Fork 62.5k
Style guide fixes #17428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style guide fixes #17428
Conversation
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
|
@Rick-Anderson |
A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days. |
@Rick-Anderson We won’t be accepting this change, as our style guide indicates we start with the initiating action before the result 💛 . Thanks so much for your time in contributing to the GitHub docs 💖 . |
@ramyaparimi but the content is incorrect. Mentioning is not enough to close the issue. That's why I added a link. |
@Rick-Anderson Thanks so much for reaching out. I will triage this for the team to take a closer look at the changes. Thank you for your patience and passion in contributing to the GitHub docs 💖 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution to the GitHub Docs! We'll merge the addition of a link to the article on keywords shortly.
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Thanks for accepting my PR. I get too many PR's such with various adjectives That don't automatically close, so I'm trying to educate new folks by pointing to a GitHub doc like this. But with this accepted PR, it sounds like just linking the PR automatically closes it, which is not true
So it's not a one stop article. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Привет давай знакомиться я я Серёга
Why:
Style guide fixes. Shorter sentences are easier for native speakers and are far better for MT (Machine Translation).
What's being changed:
Check off the following:
Writer impact (This section is for GitHub staff members only):