Skip to content

Clarify which jobs are canceled with fail-fast #16806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2022
Merged

Clarify which jobs are canceled with fail-fast #16806

merged 2 commits into from
Apr 4, 2022

Conversation

michaelosthege
Copy link
Contributor

Why:

Closes #16401

What's being changed:

Just a few words in the documentation of the fail-fast setting.

Thanks @lucascosti for providing the information.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Apr 4, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 4, 2022
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert and removed triage Do not begin working on this issue until triaged by the team waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert labels Apr 4, 2022
ramyaparimi
ramyaparimi approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@ramyaparimi ramyaparimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelosthege
Thanks so much for opening a PR with this fix! I'll get this merged once tests are passing 🍏

@ramyaparimi ramyaparimi added the ready to merge This pull request is ready to merge label Apr 4, 2022
@ramyaparimi ramyaparimi enabled auto-merge April 4, 2022 14:24
@ramyaparimi ramyaparimi merged commit 4b20a89 into github:main Apr 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@michaelosthege michaelosthege deleted the fix-16401 branch April 4, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramyaparimi ramyaparimi ramyaparimi approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Milestone
No milestone
2 participants
@michaelosthege @ramyaparimi