Skip to content

Creating a pull request template for your repository: resolve link rot #15816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 25, 2022
Merged

Creating a pull request template for your repository: resolve link rot #15816

merged 4 commits into from
Feb 25, 2022

Conversation

dylmye
Copy link
Contributor

@dylmye dylmye commented Feb 24, 2022

Why:

Closes #15815

What's being changed:

Updates the relevant link as specified in the issue ticket

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Feb 24, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 24, 2022
@ramyaparimi ramyaparimi added communities Content related to Communities content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 24, 2022
@ramyaparimi
Copy link
Contributor

@dylmye
Thanks so much for opening a PR! I'll get this triaged for review ⚡

mchammer01
mchammer01 approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@mchammer01 mchammer01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dylmye 👋🏻 - thanks for improving our Docs ✨
I tried to make a suggestion to modify the hyperlinked text (the linked article has changed so we should not only edit the URL but also the hyperlinked text) but wasn't able to do so, so I committed the change directly onto your branch.
This is good to go 🎉

@mchammer01 mchammer01 merged commit bf44de6 into github:main Feb 25, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@dylmye dylmye deleted the patch-2 branch February 28, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucalves lucalves lucalves left review comments

@mchammer01 mchammer01 mchammer01 approved these changes

Assignees
No one assigned
Labels
communities Content related to Communities content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link rot in creating-a-pull-request-template-for-your-repository
4 participants
@dylmye @ramyaparimi @lucalves @mchammer01