Skip to content

Clarify which Feather icons aren't supported. #15700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 22, 2022
Merged

Clarify which Feather icons aren't supported. #15700

merged 3 commits into from
Feb 22, 2022

Conversation

Kurt-von-Laven
Copy link
Contributor

@Kurt-von-Laven Kurt-von-Laven commented Feb 22, 2022 •
edited
Loading

Also, document the current version of Feather icons at time of writing. When additional icons are released in the future, including the version of Feather at the time our documentation was last updated will help developers realize that the newly added icons are not yet available.

Why:

Closes #10177

What's being changed:

Refer to rich diff.

Check off the following:

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 22, 2022
@Kurt-von-Laven
Clarify which Feather icons aren't supported.
b6066b2 
Also, document the current version of Feather icons at time of writing.
When additional icons are released in the future, including the version
of Feather at the time our documentation was last updated will help
developers realize that the newly added icons are not yet available.
@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 22, 2022
@ramyaparimi
Copy link
Contributor

@Kurt-von-Laven
Thanks so much for opening a PR! I'll get this triaged for review ⚡

skedwards88
skedwards88 approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding these details! We'll get this merged down for you.

@skedwards88 skedwards88 enabled auto-merge (squash) February 22, 2022 21:09
@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Feb 22, 2022
@skedwards88 skedwards88 mentioned this pull request Feb 22, 2022
Closed
5 tasks
@skedwards88 skedwards88 merged commit 2584e88 into github:main Feb 22, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@Kurt-von-Laven Kurt-von-Laven deleted the patch-3 branch February 23, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skedwards88 skedwards88 skedwards88 approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document Version of Feather Icons In Use
3 participants
@Kurt-von-Laven @ramyaparimi @skedwards88