Skip to content

chore: Remove bolding from headings #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2020
Merged

chore: Remove bolding from headings #1389

merged 2 commits into from
Dec 2, 2020

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Nov 16, 2020 •
edited
Loading

Why:

Headings already have bold font weighing, so the extra <strong> tags aren't needed

What's being changed:

Remove ** from headings so extra <strong> tags aren't added

Check off the following:

nschonni
nschonni commented Nov 16, 2020
View reviewed changes
content/actions/creating-actions/metadata-syntax-for-github-actions.md
@@ -22,19 +22,19 @@ Docker and JavaScript actions require a metadata file. The metadata filename mus

Action metadata files use YAML syntax. If you're new to YAML, you can read "[Learn YAML in five minutes](https://www.codeproject.com/Articles/1214409/Learn-YAML-in-five-minutes)."

### **`name`**
### `name`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually does come out a little lighter, but I didn't dig into the CSS on why

Copy link
Contributor

@shati-patel shati-patel Dec 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, there's a slight visual difference, but that seems fine to me 🙂

@janiceilene
Copy link
Contributor

Thanks @nschonni! I'll triage this for review ✨

@janiceilene janiceilene added the engineering Will involve Docs Engineering label Nov 17, 2020
@chiedo
Copy link
Contributor

chiedo commented Nov 17, 2020

@janiceilene this is content! Can you assign to the Docs Content team?

@chiedo chiedo added triage Do not begin working on this issue until triaged by the team and removed engineering Will involve Docs Engineering labels Nov 17, 2020
@janiceilene
Copy link
Contributor

🙈 Thanks for catching that @chiedo!

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team core and removed triage Do not begin working on this issue until triaged by the team labels Nov 17, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 25, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Nov 30, 2020
@shati-patel shati-patel self-assigned this Dec 2, 2020
shati-patel
shati-patel approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tidying up all these headings, @nschonni! 🎉 I agree, we don't need them to be bold 👍🏽

I'll get this merged shortly!

@shati-patel shati-patel merged commit 75ef2f6 into github:main Dec 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@nschonni nschonni deleted the bold-headers branch December 2, 2020 15:10
This was referenced Dec 2, 2020
Merged
Merged
Merged
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
@charislam @Loquacity
[Caggs] Clarify real-time aggregates (github#1389)
71ccecf 
The text in a particular callout was a bit confusing in terms of whether
real-time aggregates are the default behavior.

Co-authored-by: Lana Brindley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shati-patel shati-patel shati-patel approved these changes

Assignees

@shati-patel shati-patel

Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nschonni @janiceilene @chiedo @shati-patel