Skip to content

Commit d4a60c9

Browse files
authored
Merge pull request #26208 from github/repo-sync
Repo sync
2 parents 5d3cb23 + 07dcb8c commit d4a60c9

File tree

8 files changed

+12
-36
lines changed

8 files changed

+12
-36
lines changed

.github/workflows/test.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ jobs:
4949
{ name: 'graphql', path: 'src/graphql/tests', },
5050
{ name: 'landings', path: 'src/landings/tests', },
5151
{ name: 'linting', path: 'src/content-linter/tests', },
52-
{ name: 'meta', path: 'tests/meta', },
5352
{ name: 'observability', path: 'src/observability/tests' },
5453
{ name: 'pageinfo', path: 'src/pageinfo/tests', },
5554
{ name: 'rendering', path: 'tests/rendering', },

contributing/code-annotations.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ For more experienced users, code annotations can help them understand a code exa
1717

1818
An annotated code example must start with a single line annotation. You can start with a blank annotation if you do not want to add an annotation to the first line of code.
1919

20-
You must use the comment tag for the language that the code sample is written in. For example, `#` for YAML and `//` for Ruby.
20+
You must use the comment tag for the language that the code sample is written in. For example, `#` for YAML and `//` for JavaScript.
2121

2222
To enable code sample annotations, you must specify a language followed by the word `annotate` after the starting triple backtick code tag.
2323

lib/enterprise-server-releases.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export const dates = JSON.parse(await fs.readFile('src/ghes-releases/lib/enterpr
1212
export const next = '3.10'
1313
export const nextNext = '3.11'
1414

15-
export const supported = ['3.9', '3.8', '3.7', '3.6', '3.5', '3.4']
15+
export const supported = ['3.9', '3.8', '3.7', '3.6', '3.5']
1616

1717
// Ensure that:
1818
// "next" is ahead of "latest" by one minor or major release.
@@ -37,7 +37,7 @@ function isValidNext(v1, v2) {
3737
// When you're archiving a version, add the new archived number to this
3838
// array and you should never need to touch the `deprecated` array
3939
// on the line just below.
40-
export const deprecatedWithFunctionalRedirects = ['3.3', '3.2', '3.1', '3.0']
40+
export const deprecatedWithFunctionalRedirects = ['3.4', '3.3', '3.2', '3.1', '3.0']
4141
export const deprecated = [
4242
...deprecatedWithFunctionalRedirects,
4343
'2.22',

src/content-linter/tests/lint-versioning.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@ function validateIfversionConditionals(conds) {
157157
// allows us to deprecate the version before removing
158158
// the old liquid content.
159159
if (
160+
version !== 'ghae' &&
160161
!(
161162
supported.includes(release) ||
162163
release === next ||

src/rest/scripts/test-open-api-schema.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import frontmatter from '../../../lib/read-frontmatter.js'
1313
import getApplicableVersions from '../../../lib/get-applicable-versions.js'
1414
import { allVersions, getDocsVersion } from '../../../lib/all-versions.js'
1515
import { REST_DATA_DIR, REST_SCHEMA_FILENAME } from '../lib/index.js'
16+
import { deprecated } from '../../../lib/enterprise-server-releases.js'
1617

1718
const contentFiles = []
1819

@@ -52,7 +53,11 @@ export async function getDiffOpenAPIContentRest() {
5253

5354
async function createOpenAPISchemasCheck() {
5455
const openAPICheck = createCheckObj()
55-
const restDirectory = fs.readdirSync(REST_DATA_DIR).filter((dir) => !dir.endsWith('.json'))
56+
const restDirectory = fs
57+
.readdirSync(REST_DATA_DIR)
58+
.filter((dir) => !dir.endsWith('.json'))
59+
// Allow the most recent deprecation to exist on disk until fully deprecated
60+
.filter((dir) => !dir.includes(deprecated[0]))
5661

5762
restDirectory.forEach((dir) => {
5863
const filename = path.join(REST_DATA_DIR, dir, REST_SCHEMA_FILENAME)

tests/fixtures/content/get-started/liquid/ifversion.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ condition-l
6767

6868
{% ifversion ghes %}
6969
condition-m
70-
{% ifversion ghes = 3.4 %}
70+
{% ifversion ghes = 3.5 %}
7171
condition-n
7272
{% endif %}
7373
{% endif %}

tests/meta/orphan-tests.js

Lines changed: 0 additions & 21 deletions
This file was deleted.

tests/rendering-fixtures/liquid.js

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -154,15 +154,6 @@ describe('extended Markdown', () => {
154154
'condition-l',
155155
],
156156
'enterprise-cloud@latest': ['condition-c', 'condition-j', 'condition-l'],
157-
158-
'condition-c',
159-
'condition-e',
160-
'condition-g',
161-
'condition-i',
162-
'condition-j',
163-
'condition-m',
164-
'condition-n',
165-
],
166157
167158
'condition-c',
168159
'condition-e',
@@ -172,6 +163,7 @@ describe('extended Markdown', () => {
172163
'condition-i',
173164
'condition-k',
174165
'condition-m',
166+
'condition-n',
175167
'condition-o',
176168
],
177169

0 commit comments

Comments
 (0)