Merge pull request #23049 from github/repo-sync

repo sync

Author: Octomerger

.devcontainer/devcontainer.json

@@ -17,7 +17,6 @@
 
 	// Install features. Type 'feature' in the VS Code command palette for a full list.
 	"features": {
-		"git-lfs": "latest",
 		"sshd": "latest"
 	 },
 
@@ -42,7 +41,7 @@
 	},
 
 	// Use 'postCreateCommand' to run commands after the container is created.
-	"postCreateCommand": "git lfs pull && npm ci",
+	"postCreateCommand": "npm ci",
 
 	// Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
 	"remoteUser": "node"

.github/actions-scripts/enterprise-server-issue-templates/release-issue.md

@@ -101,7 +101,7 @@ This file should be automatically updated, but you can also run `script/update-e
 
 ### 🚢 🛳️ 🚢 Shipping the release branch
 
-- [ ] The megabranch creator should push the search index LFS objects for the public `github/docs` repo. The LFS objects were already pushed for the internal repo after the `sync-english-index-for-<PLAN@RELEASE>` was added to the megabranch. To push the LFS objects to the public repo:
+- [ ] Sync the search indices for the new release:
   1. First navigate to the [sync search indices workflow](https://github.com/github/docs-internal/actions/workflows/sync-search-indices.yml). 
   2. Then, to run the workflow with parameters, click on `Run workflow` button. 
   3. A modal will pop up where you will set the following inputs:

.github/workflows/azure-preview-env-deploy.yml

@@ -91,7 +91,6 @@ jobs:
         with:
           ref: 'main'
           persist-credentials: 'false'
-          lfs: 'true'
 
       - if: ${{ env.IS_INTERNAL_BUILD == 'true' }}
         name: Check out PR code
@@ -100,10 +99,6 @@ jobs:
           ref: ${{ env.COMMIT_REF }}
           # To prevent issues with cloning early access content later
           persist-credentials: 'false'
-          lfs: 'true'
-
-      - name: Check out LFS objects
-        run: git lfs checkout
 
       - name: Get preview app info
         env:

.github/workflows/azure-staging-build-deploy.yml

@@ -65,10 +65,6 @@ jobs:
           ref: ${{ env.COMMIT_REF }}
           # To prevent issues with cloning early access content later
           persist-credentials: 'false'
-          lfs: 'true'
-
-      - name: Check out LFS objects
-        run: git lfs checkout
 
       - name: 'Set env vars'
         run: |

.github/workflows/browser-test.yml

@@ -50,11 +50,6 @@ jobs:
 
       - name: Checkout
         uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
-        with:
-          lfs: true
-
-      - name: Checkout LFS objects
-        run: git lfs checkout
 
       - name: Setup Node
         uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516

.github/workflows/content-changes-table-comment.yml

@@ -75,7 +75,7 @@ jobs:
         run: .github/actions-scripts/content-changes-table-comment.js
 
       - name: Find content directory changes comment
-        uses: peter-evans/find-comment@1769778a0c5bd330272d749d12c036d65e70d39d
+        uses: peter-evans/find-comment@f4499a714d59013c74a08789b48abe4b704364a0
         id: findComment
         with:
           issue-number: ${{ github.event.pull_request.number }}

.github/workflows/enterprise-dates.yml

@@ -55,7 +55,7 @@ jobs:
 
       - name: Create pull request
         id: create-pull-request
-        uses: peter-evans/create-pull-request@bd72e1b7922d417764d27d30768117ad7da78a0e
+        uses: peter-evans/create-pull-request@2b011faafdcbc9ceb11414d64d0573f37c774b04
         env:
           # Disable pre-commit hooks; they don't play nicely here
           HUSKY: '0'

.github/workflows/main-preview-docker-cache.yml

@@ -49,10 +49,6 @@ jobs:
         with:
           # To prevent issues with cloning early access content later
           persist-credentials: 'false'
-          lfs: 'true'
-
-      - name: Check out LFS objects
-        run: git lfs checkout
 
       - if: ${{ env.ENABLE_EARLY_ACCESS }}
         name: Clone docs-early-access

.github/workflows/repo-sync.yml

@@ -100,7 +100,10 @@ jobs:
       - name: Check out repo
         uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
 
-      # Set up npm and run npm ci to run husky to get githooks for LFS
+      # Set up npm and run npm ci to get custom husky githooks error
+      # messages if they exist. We could also remove these two steps
+      # because currently we have no hooks with customer error messages.
+      # See pull #32064 where they were removed.
       - name: Setup node
         uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516
         with:

.github/workflows/test.yml

@@ -66,15 +66,6 @@ jobs:
       # Even if if doesn't do anything
       - name: Check out repo
         uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
-        with:
-          # Not all test suites need the LFS files. So instead, we opt to
-          # NOT clone them initially and instead, include them manually
-          # only for the test groups that we know need the files.
-          lfs: ${{ matrix.test-group == 'content' }}
-          # Enables cloning the Early Access repo later with the relevant PAT
-          # persist-credentials: 'false'
-          # ->> Do we really need this? actions/checkout doesn't use it for the nested example:
-          # https://github.com/actions/checkout#checkout-multiple-repos-nested
 
       - name: Setup node
         uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516
@@ -172,11 +163,6 @@ jobs:
           token: ${{ secrets.DOCUBOT_REPO_PAT }}
           path: translations/ko-kr
 
-      # This is necessary when LFS files where cloned but does nothing
-      # if actions/checkout was run with `lfs:false`.
-      - name: Checkout LFS objects
-        run: git lfs checkout
-
       - name: Gather files changed
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}