Openssl acronym normalization #19785
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calls that return a known algorithm and calls that operate on a known algorithm. update KnownAlgorithmConstants to correct algType for signature algorithms. Update all instances and prior uses of the old mechanic to KnownAlgorithmConstants.
… that is an argument or a return.
…dd initial signature tests (no expected files yet). Add new openssl .h stubs. Clean up of OperationBase and associated uses. Update test case stubs to be closer to the actual stubs. Fix unncessary instanceof check in signatures.
…tep to handle paramgen. Remove redundant test. Overhaul of EVP update/initializer/final mechanics. Misc. updates for new API and refactoring EVPKeyGenOperation. Clean up of keygen_operaitons.ql.
… initializer subclasses.
…del update. Remove setting RSA bits as an RSA algorithm. Fix bug in hash algorithm. Add missing PKey encryption to cipher ops. Consolidate ctx initializers. Add unit tests, and alter unit test directory structure to allow for application to other APIs. Update expected files for unit tests (not all updated yet, a work in progress).
…properties that configure downstream operations. Add key size tests
…to disallow null key and IV on initializers (typically do not represent an actual key or IV).
…. Update model to account for MAC algorithms.
…n and correct handling of MACs.
… for now and noting the issue for a future PR.
…des/codeql into pawel_signatures_conversion
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/MACAlgorithmInstance.qll
Fixed
Show fixed
Hide fixed
cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/PaddingAlgorithmInstance.qll
Fixed
Show fixed
Hide fixed
...l/lib/experimental/quantum/OpenSSL/AlgorithmValueConsumers/PaddingAlgorithmValueConsumer.qll
Fixed
Show fixed
Hide fixed
Comment on lines
+70
to
+74
| * The context is the context coming into the initializer and is the output as well. | ||
| * This is assumed to be the same argument. | ||
| */ | ||
| Expr getContextArg() { result = this.(Call).getArgument(0) } | ||
| abstract CtxPointerSource getContext(); | ||
| } |
Check warning
Code scanning / CodeQL
Class QLDoc style. Warning
| Crypto::AlgorithmValueConsumer getAlgorithmValueConsumer() { | ||
| argToAvc(this.getAlgorithmArg(), result) | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Redundant override Warning
bdrodes
force-pushed
the
openssl_acronym_normalization
branch
from
557cfd4 to
7c18686
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct acronyms to pass ql-for-ql tests. Fix any additional ql-for-ql alert fails as well.