JS: Support Typescript 5.6 #17164
Closed
JS: Support Typescript 5.6 #17164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
reviewed
Sep 10, 2024
Co-authored-by: Erik Krogh Kristensen <[email protected]>
…deql into sidshank/ts-5.6-update
erik-krogh
reviewed
Sep 10, 2024
Comment on lines
1210
to
1212
| isNamespaceExportNode | ||
| ? Collections.singletonList(convertNodeAsIdentifier(exportClauseNode.getAsJsonObject())) | ||
| : convertChildren(exportClauseNode.getAsJsonObject(), "elements"); |
There was a problem hiding this comment.
Could you add a test for this specific syntax?
There was a problem hiding this comment.
Will do. I'm taking a look at convertImportDeclaration to see if I need to make similar changes there. Once I figure that out (and make the changes if necessary), I'll add tests.
|
Closing in favour of: #17433 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables CodeQL analysis of code using TypeScript 5.6 features. Notably, the use of arbitrary import/export specifiers is now supported. Ref 1, 2
Release announcement here: https://devblogs.microsoft.com/typescript/announcing-typescript-5-6/