Skip to content

C++: Also clear the 0'th argument of swap #15537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2024
Merged

C++: Also clear the 0'th argument of swap #15537

merged 1 commit into from
Feb 7, 2024

Conversation

MathiasVP
Copy link
Contributor

@MathiasVP MathiasVP commented Feb 7, 2024 •
edited
Loading

In #15528 I forgot to model that std::swap also clears the 0'th argument. This PR fixes that.

DCA looks uneventful. There are two failing projects because of a known bug in DCA that is being worked on as we speak. This shouldn't block this PR, though.

@MathiasVP MathiasVP requested a review from a team as a code owner February 7, 2024 10:32
@github-actions github-actions bot added the C++ label Feb 7, 2024
@MathiasVP MathiasVP added the no-change-note-required This PR does not need a change note label Feb 7, 2024
geoffw0
geoffw0 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I've waited a long time for this improvement!

@MathiasVP MathiasVP merged commit 23677b2 into github:main Feb 7, 2024
MathiasVP added a commit to MathiasVP/ql that referenced this pull request Feb 9, 2024
@MathiasVP
Revert "Merge pull request github#15537 from MathiasVP/swap-also-clea…
4e16257 
…rs-first-argument"

This reverts commit 23677b2, reversing
changes made to c5dc883.
MathiasVP added a commit to MathiasVP/ql that referenced this pull request Feb 13, 2024
@MathiasVP
Revert "Merge pull request github#15537 from MathiasVP/swap-also-clea…
a1d3a22 
…rs-first-argument"

This reverts commit 23677b2, reversing
changes made to c5dc883.
MathiasVP added a commit to MathiasVP/ql that referenced this pull request Feb 13, 2024
@MathiasVP
Revert "Merge pull request github#15537 from MathiasVP/swap-also-clea…
cb7fe16 
…rs-first-argument"

This reverts commit 23677b2, reversing
changes made to c5dc883.
@MathiasVP MathiasVP mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees
No one assigned
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MathiasVP @geoffw0