JS: push more context into load/store steps from the exploratory flow-analysis #10986
Conversation
|
When the cache size is reported to be exactly '1.032' (as it is here), we suspect an unknown cache cleanup step to have happened. This has happened ~3 times in a few months. |
There was a problem hiding this comment.
Implementation LGTM but the evaluation looks a bit underwhelming now that the other PR has been merged. It's leaning towards a slodown, with a 17s increase in vscode being the worst offender. Maybe that was just an unlucky run, but if it's really just trading a speedup in one project for a slowdown in another, I'm not sure we should merge it.
I did a repeat evaluation: https://github.com/github/codeql-dca-main/tree/data/erik-krogh/pr-10986-21e7e2__default__code-scanning__1/reports |
Saves an additional 15s (out of ~6 minutes) when running the code-scanning suite on the database from #10937
Evaluation looks somewhat uneventful.
I'm pretty sure the cache size is just noise.