Skip to content

Swift: move libraries from tools to third_party #10983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2022
Merged

Swift: move libraries from tools to third_party #10983

merged 1 commit into from
Oct 26, 2022

Conversation

redsun82
Copy link
Contributor

@redsun82 redsun82 commented Oct 26, 2022 •
edited
Loading

I did this as part of something I was trying out that ended up not really requiring this cleanup, but I guessed it still made sense.

@github-actions github-actions bot added the Swift label Oct 26, 2022
@redsun82 redsun82 marked this pull request as ready for review October 26, 2022 06:24
@redsun82 redsun82 requested review from a team as code owners October 26, 2022 06:24
@redsun82 redsun82 requested a review from AlexDenisov October 26, 2022 06:24
jketema
jketema approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and seems more consistent with what we do internally.

@redsun82 redsun82 merged commit a323450 into main Oct 26, 2022
@redsun82 redsun82 deleted the redsun82/swift-third-party branch October 26, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jketema jketema jketema approved these changes

@AlexDenisov AlexDenisov Awaiting requested review from AlexDenisov

Assignees
No one assigned
Labels
Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redsun82 @jketema