Skip to content

Swift: Fix UrlRemoteFlowSource name clash #10973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2022
Merged

Swift: Fix UrlRemoteFlowSource name clash #10973

merged 2 commits into from
Oct 25, 2022

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Oct 25, 2022

Fix UrlRemoteFlowSource name clash (with UrlRemoteFlowSource in Url.qll) and add qldoc comment. I'm not aware of any consequences the name clash was having, but it can't be a good thing.

@geoffw0 geoffw0 added no-change-note-required This PR does not need a change note Swift labels Oct 25, 2022
@geoffw0 geoffw0 requested a review from a team as a code owner October 25, 2022 16:01
atorralba
atorralba approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that.

@geoffw0 geoffw0 merged commit 1e8b4bd into github:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atorralba atorralba atorralba approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoffw0 @atorralba